-
Notifications
You must be signed in to change notification settings - Fork 3
feat(french-cert): add schemas for reprints store and retrieve accord… #558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
@@ -0,0 +1,59 @@ | |||
module.exports = { | |||
duplicate_id: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unclear and bad name
@@ -0,0 +1,59 @@ | |||
module.exports = { | |||
duplicate_id: { | |||
description: 'Identifier of the duplicate', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant and unclear
@@ -0,0 +1,59 @@ | |||
module.exports = { | |||
duplicate_id: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who is issuing that data?
type: 'string' | ||
}, | ||
original_number: { | ||
description: 'Unique original document number', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant and does not specify the origin
example: 'cashier-7', | ||
type: 'string' | ||
}, | ||
reason: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this be really only text?
48865a9
to
8d4dd60
Compare
…ing to NF-525
https://tillhub.atlassian.net/browse/API-752