Skip to content

Implement a wait for touch function #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 7, 2024
Merged

Implement a wait for touch function #28

merged 7 commits into from
Feb 7, 2024

Conversation

mchack-work
Copy link
Member

@mchack-work mchack-work commented Jan 29, 2024

  • Add a function getled() to get current LED value
  • Add touchwait() using a hardware timer for timeout and blink and touched().
  • Fix include guards.
  • Format Makefile

Fixes #29

@mchack-work mchack-work requested a review from dehanj January 29, 2024 13:08
@dehanj

This comment was marked as outdated.

@mchack-work mchack-work marked this pull request as draft January 31, 2024 21:17
@mchack-work
Copy link
Member Author

New version of touchwait() added with hardware timer for timeout and blink.

@mchack-work
Copy link
Member Author

Still needs squashing and cleaning up history.

@mchack-work mchack-work changed the title Add get_led() function Move wait for touch from signer Feb 1, 2024
@mchack-work mchack-work changed the title Move wait for touch from signer Implement a wait for touch function Feb 1, 2024
@dehanj
Copy link
Member

dehanj commented Feb 1, 2024

I would say I'm happy with this one now. But let's discuss on Monday.
(Except squashing etc.)

Add a function to get current LED value
@dehanj dehanj marked this pull request as ready for review February 7, 2024 12:25
@mchack-work mchack-work merged commit f0a8d09 into main Feb 7, 2024
@mchack-work mchack-work deleted the get-led branch February 7, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a wait for touch function
2 participants