Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tkey-verification: new ways of accessing compiled-in assets #19

Merged
merged 59 commits into from
Jul 3, 2024
Merged
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
03bc362
Define new way to access compiled-in assets
mchack-work Mar 7, 2024
2b6e4da
Remove show-pubkey program
mchack-work May 2, 2024
6daf3eb
Use tkeysign pkg instead of internal pkg
mchack-work May 2, 2024
1bd0df6
Update and use ordinary Go TKey packages
mchack-work May 2, 2024
5c1b98e
Introduce new way of adressing firmwares
mchack-work May 6, 2024
f920bd8
Introduce new way of accessing a TKey device
mchack-work May 7, 2024
bb89230
Include tkey-device-signer v1.0.1 binary
mchack-work May 16, 2024
f423e70
Update Makefile
mchack-work May 20, 2024
ee8c71f
Refactor remote-sign
mchack-work May 21, 2024
b0cd614
Return error when no port detected
mchack-work May 21, 2024
53792b7
remotesign/tkey: Add constant errors, fix erronoeus error handling
mchack-work May 21, 2024
c12ec55
Add show-pubkey command
dehanj May 16, 2024
f977e0a
Use goreleaser for release builds.
dehanj May 20, 2024
b07bd78
Use enumeration for Darwin, which requires CGO when building.
dehanj Jul 2, 2024
a44b3c1
Include vendor-signing-pubkeys.txt under cmd/tkey-verification
dehanj Jul 2, 2024
82be911
Remove unusued expectedPubKey argument
mchack-work May 22, 2024
23f00c8
Return errors from vendorSign
mchack-work May 22, 2024
99c2dca
Rename TlsConfig
mchack-work May 22, 2024
e57589a
Removed unused constants
mchack-work May 22, 2024
873e7b9
Remove unused wantname
mchack-work May 22, 2024
1fe8ce4
Pass server around as a pointer
mchack-work May 22, 2024
2a31c0d
Use faster hex encode function instead of printf
mchack-work May 22, 2024
161167c
Move err into the block where it's used
mchack-work May 22, 2024
6efdd7c
Revise the linting
mchack-work May 22, 2024
16a7e39
Revise comments
mchack-work May 22, 2024
350e369
Make missing binary a lint error
mchack-work May 22, 2024
8e35333
Remove verisigner and associated build scripts
dehanj May 23, 2024
0e1aa94
Move initialization of vendor keys, app bins, ... to commands
mchack-work Jun 5, 2024
1e1f481
Attempt to handle errors more elegantly
mchack-work Jun 5, 2024
f7f6b86
Convert man page to scdoc
mchack-work Jun 5, 2024
e14de43
Add show-pubkey to man page
mchack-work Jun 5, 2024
6d021cd
Add SPDX check script
mchack-work Jun 11, 2024
2eb0e1c
Golang CI: Change goerr113 name
mchack-work Jun 11, 2024
10b4ba0
Add CI config
mchack-work Jun 11, 2024
7aa4e6e
Add generated man page as a courtesy
mchack-work Jun 11, 2024
8bded44
Change certificate generation
mchack-work Jun 11, 2024
c5ff919
Handle any signals after connecting to the TKey
mchack-work Jun 11, 2024
fa03d3f
Revise .gitignore
mchack-work Mar 7, 2024
7d1af33
Fix lint complaints and revise lint config
mchack-work Jun 11, 2024
d9028be
Silence messages
mchack-work Jun 17, 2024
e9f951f
Revise verify error reporting
mchack-work Jun 18, 2024
784f0c2
Add some whitespace when printing parsed UDI
mchack-work Jun 18, 2024
2805f91
man: Include output in verify example + man make target
mchack-work Jun 18, 2024
220c480
Revise README
mchack-work May 20, 2024
488db7d
Refactor error handling in API
mchack-work Jun 19, 2024
9b99d05
Redo error handling
mchack-work Jun 20, 2024
cf624ea
Use exit to close TKey connection
mchack-work Jun 20, 2024
242de2e
Explicitly allow several vendor keys
mchack-work Jun 20, 2024
6ba60bf
Less complex error from Dial
mchack-work Jun 20, 2024
016f04e
Remove superfluous goroutine serve()
mchack-work Jun 20, 2024
62c448f
Add comments on our assets
mchack-work Jun 24, 2024
7cc43de
show-pubkey: Remove unused function GetByTagOnly()
mchack-work Jun 24, 2024
19a18de
Add check to see that expected tag for a public key is available
mchack-work Jun 24, 2024
365049c
Rename appbins latest -> current
mchack-work Jun 24, 2024
e71b010
Add implementation notes
mchack-work Jun 24, 2024
cac9068
Make vendor signing app digest configurable
mchack-work Jul 1, 2024
236473f
Revise remote-sign configuration
mchack-work Jul 1, 2024
3c8e02f
Add support for --speed
mchack-work Jul 2, 2024
0efa89a
Update year on copyright notice
dehanj Jul 2, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
show-pubkey: Remove unused function GetByTagOnly()
Used only by removed program show-pubkey
mchack-work authored and dehanj committed Jul 2, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 7cc43ded2bea1afdd43f545f1255eb215298b789
10 changes: 0 additions & 10 deletions cmd/tkey-verification/appbins.go
Original file line number Diff line number Diff line change
@@ -34,16 +34,6 @@ type AppBins struct {
latest string
}

// Only used by show-pubkey cmd
func (a AppBins) GetByTagOnly(tag string) (AppBin, error) {
for _, appBin := range a.Bins {
if appBin.Tag == tag {
return appBin, nil
}
}
return AppBin{}, MissingError{what: ""}
}

// Get returns an AppBin indexed by the app hash digest.
func (a AppBins) Get(hash string) (AppBin, error) {
if val, ok := a.Bins[hash]; ok {