-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refine settings javascript_max_memory_bytes and correct set hard limit #718
Open
yokofly
wants to merge
9
commits into
develop
Choose a base branch
from
bugfix/issue-716-udf-memory-limit
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* v8 heap limit less than javascript_max_memory_bytes * fix
* switch to function arg passed context, instead thread context * switch the default v8 heap soft limit from 100MB to 200 MB * move log to ctor. output like ``` 2024.03.01 23:52:39.428662 [ 200546 ] {0b772a75-c715-4ffc-8a9f-c980c835842c} <Information> JavaScriptAggregateFunction: udf name=test_sec_large, javascript_max_memory_bytes=23 ```
yokofly
force-pushed
the
bugfix/issue-716-udf-memory-limit
branch
from
December 11, 2024 05:07
6605d30
to
855596d
Compare
yokofly
changed the title
edit the v8 heap hard limit.
refine settings javascript_max_memory_bytes and correct set hard limit
Dec 11, 2024
yokofly
requested review from
sunset3000,
chenziliang and
qijun-niu-timeplus
December 11, 2024 06:06
chenziliang
reviewed
Dec 11, 2024
chenziliang
reviewed
Dec 11, 2024
chenziliang
reviewed
Dec 11, 2024
chenziliang
reviewed
Dec 11, 2024
chenziliang
reviewed
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #716
so this PR do 3 things:
for 3:
in latest proton server below query will passed, because the value is always 100MByte instead we want 2MByte.
Before this PR: Below CTE query will always use the default of 100MB. If the memory usage exceeds 100MB, trying to modify
settings javascript_max_memory_bytes=2
to 200MB will not change the outcome.Now: An error will be reported.