Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/issue 876 mac os build another patch #887

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

yokofly
Copy link
Collaborator

@yokofly yokofly commented Dec 23, 2024

Please write user-readable short description of the changes:
fix #876
so below patch tries to fix macOS ARM linker warn and solve previous stacktrace unwind stuck

@yokofly
Copy link
Collaborator Author

yokofly commented Dec 23, 2024

I triggered a manual test and the binary is here: s3://tp-internal/proton/native_build_macOS/proton_450dd04957_arm64
but we still need to add some smoke tests to make it can be tested.

➜  issue-876 ./proton_450dd04957_arm64 client
proton client version 1.6.6.
Connecting to localhost:8463 as user default.
Connected to proton server version 1.6.6 revision 54459.

Warnings:
 * Maximum number of threads is lower than 30000. There could be problems with handling a lot of simultaneous queries.

res-mac-mini.local :) select version(), date(now())

SELECT
  version(), date(now())

Query id: 0ed4f18c-b66d-4386-8546-8380cd42ff6d

┌─version()─┬─date(now())─┐
│ 1.6.6     │  2024-12-23 │
└───────────┴─────────────┘

1 row in set. Elapsed: 0.003 sec. 

res-mac-mini.local :) 

@yokofly yokofly merged commit 19d53b4 into develop Dec 23, 2024
12 of 19 checks passed
@yokofly yokofly deleted the bugfix/issue-876-macOS-build-another-patch branch December 23, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot start proton server on macOS with bare metal binary
1 participant