Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/issue 914 clang 19 #916

Merged
merged 13 commits into from
Mar 4, 2025
Merged

Bugfix/issue 914 clang 19 #916

merged 13 commits into from
Mar 4, 2025

Conversation

yokofly
Copy link
Collaborator

@yokofly yokofly commented Mar 1, 2025

Please write user-readable short description of the changes:
Try fixing the clang19 build. The key is flatbuffer required an upgrade, but considering the protobuff is out of date, I bumped it up as well. Some basic test cases have already run.

test log

with proton 1.6.11-rc:

2025-03-03 06:00:55.629+0800 <debug> Executor: Task finished: Cluster[p1k1], Suite[external_stream], Case[21_check_syntax_properties_04], Tags: [smoke, kafka, external_stream, smoke, kafka, external_stream], Duration[2.004627042s]
2025-03-03 06:00:55.629+0800 <debug> Executor: Task canceled
2025-03-03 06:00:56.631+0800 <info> Collector: Collected 16 cases

2025-03-03 06:00:56.631+0800 <info> Gatherer: Cluster: p1k1
2025-03-03 06:00:56.631+0800 <info> Gatherer:   - Suite: external_stream
2025-03-03 06:00:56.631+0800 <info> Gatherer:     - Case: 01_seek_to_earlist (succeed)(12.285195753s)
2025-03-03 06:00:56.631+0800 <info> Gatherer:     - Case: 03_multi_shard (succeed)(14.26459975s)
2025-03-03 06:00:56.631+0800 <info> Gatherer:     - Case: 04_multi_shard_seek_to (succeed)(14.240189045s)
2025-03-03 06:00:56.631+0800 <info> Gatherer:     - Case: 05_multi_shard_sharding_rule (succeed)(14.297999485s)
2025-03-03 06:00:56.631+0800 <info> Gatherer:     - Case: 06_drop_stream (succeed)(222.816675ms)
2025-03-03 06:00:56.631+0800 <info> Gatherer:     - Case: 07_json_string_parse_from_external_stream (succeed)(8.24669921s)
2025-03-03 06:00:56.631+0800 <info> Gatherer:     - Case: 08_table_function (failed)(9.250056548s)
2025-03-03 06:00:56.631+0800 <info> Gatherer:     - Case: 10_window_aggr (succeed)(8.02390679s)
2025-03-03 06:00:56.631+0800 <info> Gatherer:     - Case: 13_message_key (failed)(7.259849624s)
2025-03-03 06:00:56.631+0800 <info> Gatherer:     - Case: 14_kafka_complex_type (failed)(18.260906951s)
2025-03-03 06:00:56.631+0800 <info> Gatherer:     - Case: 16_message_key_mv (failed)(12.316024446s)
2025-03-03 06:00:56.631+0800 <info> Gatherer:     - Case: 17_exception_message_key_and_sharding_expr_cannot_be_used_together (failed)(13.527987ms)
2025-03-03 06:00:56.631+0800 <info> Gatherer:     - Case: 18_check_syntax_properties_01 (succeed)(13.353440829s)
2025-03-03 06:00:56.631+0800 <info> Gatherer:     - Case: 19_check_syntax_properties_02 (failed)(2.012857558s)
2025-03-03 06:00:56.631+0800 <info> Gatherer:     - Case: 20_check_syntax_properties_03 (failed)(2.004315992s)
2025-03-03 06:00:56.631+0800 <info> Gatherer:     - Case: 21_check_syntax_properties_04 (failed)(2.004627042s)
2025-03-03 06:00:56.631+0800 <debug> Gatherer: Gather done
➜  cluster git:(develop) ✗      

proton new version

2025-03-03 06:07:28.402+0800 <debug> Executor: Task canceled
2025-03-03 06:07:29.403+0800 <info> Collector: Collected 16 cases

2025-03-03 06:07:29.403+0800 <info> Gatherer: Cluster: p1k1
2025-03-03 06:07:29.403+0800 <info> Gatherer:   - Suite: external_stream
2025-03-03 06:07:29.403+0800 <info> Gatherer:     - Case: 01_seek_to_earlist (succeed)(12.283824629s)
2025-03-03 06:07:29.403+0800 <info> Gatherer:     - Case: 03_multi_shard (succeed)(14.270218699s)
2025-03-03 06:07:29.403+0800 <info> Gatherer:     - Case: 04_multi_shard_seek_to (succeed)(14.251131909s)
2025-03-03 06:07:29.403+0800 <info> Gatherer:     - Case: 05_multi_shard_sharding_rule (succeed)(14.368593304s)
2025-03-03 06:07:29.403+0800 <info> Gatherer:     - Case: 06_drop_stream (succeed)(221.650008ms)
2025-03-03 06:07:29.403+0800 <info> Gatherer:     - Case: 07_json_string_parse_from_external_stream (succeed)(8.24924258s)
2025-03-03 06:07:29.403+0800 <info> Gatherer:     - Case: 08_table_function (failed)(9.242740041s)
2025-03-03 06:07:29.403+0800 <info> Gatherer:     - Case: 10_window_aggr (succeed)(8.019431667s)
2025-03-03 06:07:29.403+0800 <info> Gatherer:     - Case: 13_message_key (failed)(7.261456875s)
2025-03-03 06:07:29.403+0800 <info> Gatherer:     - Case: 14_kafka_complex_type (failed)(18.239344161s)
2025-03-03 06:07:29.403+0800 <info> Gatherer:     - Case: 16_message_key_mv (failed)(12.298311491s)
2025-03-03 06:07:29.403+0800 <info> Gatherer:     - Case: 17_exception_message_key_and_sharding_expr_cannot_be_used_together (failed)(12.585136ms)
2025-03-03 06:07:29.403+0800 <info> Gatherer:     - Case: 18_check_syntax_properties_01 (succeed)(13.344030237s)
2025-03-03 06:07:29.403+0800 <info> Gatherer:     - Case: 19_check_syntax_properties_02 (failed)(2.012186475s)
2025-03-03 06:07:29.403+0800 <info> Gatherer:     - Case: 20_check_syntax_properties_03 (failed)(2.014798914s)
2025-03-03 06:07:29.403+0800 <info> Gatherer:     - Case: 21_check_syntax_properties_04 (failed)(2.011851476s)
2025-03-03 06:07:29.403+0800 <debug> Gatherer: Gather done
➜  cluster git:(develop) ✗ 

yokofly and others added 5 commits February 28, 2025 07:00
* Bump protobuf to v3.18.x (ref: ClickHouse/ClickHouse#50400)

* Bump protobuf to v3.19.6 (ref: ClickHouse/ClickHouse#55963)

* Bump protobuf to v3.19.6 (ref: ClickHouse/ClickHouse#50920)

* Update contribe/orc (ref: ClickHouse/ClickHouse#53324)

* Bump protobuf to v21.9 (ref: ClickHouse/ClickHouse#56014)

* Removed unused code in google-protobuf-cmake/CMakeLists.txt (ref: ClickHouse/ClickHouse#56102)

* Bump gRPC to v1.55.4 and protobuf to v22.5 (ref: ClickHouse/ClickHouse#56664)

* Bump gRPC to v1.59 and protobuf to v24.4 (ref: ClickHouse/ClickHouse#56853)

* enable functions in readonly mode (ref: ClickHouse/ClickHouse#42708)

* Introduce more fields for in-source function documentation (ref: ClickHouse/ClickHouse#49300)

* Add ability to convert timeplusd table structure to CapnProto/Protobuf format schema (ref: ClickHouse/ClickHouse#52278)

* Well known protos (ref: ClickHouse/ClickHouse#56741)

* Update protobuf to v25.1 (ref: ClickHouse/ClickHouse#58020)

* fixed unit_tests_dbms build

* Avoid ignoring errors of execute_process() (set COMMAND_ERROR_IS_FATAL=ANY) (ref: ClickHouse/ClickHouse#68267)

* fixed reigsterFunction

* fixed error after rebase
* Merge pull request #51710 from velavokr/velavokr-warn-cpu-utilization

A cmake warning on job limits underutilizing CPU

* Merge pull request #52196 from rschu1ze/simplify-job-limiting

CMake: Simplify job limiting

* Merge pull request #56971 from ClickHouse/own-cmake-for-grpc

Own CMake for GRPC

* Merge pull request #70671 from ClickHouse/fix-native-macos

Fix native macOS build

---------

Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
Co-authored-by: Robert Schulze <robert@clickhouse.com>
Co-authored-by: Konstantin Bogdanov <thevar1able@users.noreply.github.com>
@yokofly yokofly self-assigned this Mar 1, 2025
@yokofly yokofly requested review from zliang-min and removed request for zliang-min March 3, 2025 10:56
@yokofly yokofly marked this pull request as draft March 3, 2025 14:20
yokofly added 4 commits March 3, 2025 06:31
 * Port ClickHouse #44132 Bump libdivide (to gain some new optimizations)

 * Merge pull request #62212 from ClickHouse/clang-19-3

 Fix build with clang-19 (master)

 * Porting ClickHouse #70412 Fix `clang-19` build issues

 * Comment out unnecessary include files to fix mac build issue

 * Port ClickHouse #70691 Bump `arrow` to v16.1.0 and `flatbuffers` to v23.5.26

 ---------

 Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
 Co-authored-by: Konstantin Bogdanov <thevar1able@users.noreply.github.com>
 Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com>

 Ported by: sunset3000 <tian.fan@timeplus.io>
`clang++-19: error: no such include directory: '/proton/src/ch_contrib::rapidjson' [-Werror,-Wmissing-include-dirs]`
@yokofly yokofly force-pushed the bugfix/issue-914-clang-19 branch from 45296d7 to 6e87806 Compare March 3, 2025 14:32
@yokofly yokofly force-pushed the bugfix/issue-914-clang-19 branch from 6e87806 to c97b232 Compare March 3, 2025 14:38
@yokofly yokofly marked this pull request as ready for review March 3, 2025 14:45
@yokofly yokofly requested a review from zliang-min March 3, 2025 14:46
Copy link
Collaborator

@zliang-min zliang-min left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment.

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2025

CLA assistant check
All committers have signed the CLA.

sorry, i need overwrite CLA.
credit: ClickHouse/ClickHouse#51285
@yokofly yokofly force-pushed the bugfix/issue-914-clang-19 branch from 2220935 to 6a70af0 Compare March 4, 2025 03:22
@yokofly yokofly merged commit 513b7f6 into develop Mar 4, 2025
2 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: "cannot assign to non-static data member" caused by obsolete version of "flatbuffer" Fail to build
4 participants