-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/issue 914 clang 19 #916
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump protobuf to v3.18.x (ref: ClickHouse/ClickHouse#50400) * Bump protobuf to v3.19.6 (ref: ClickHouse/ClickHouse#55963) * Bump protobuf to v3.19.6 (ref: ClickHouse/ClickHouse#50920) * Update contribe/orc (ref: ClickHouse/ClickHouse#53324) * Bump protobuf to v21.9 (ref: ClickHouse/ClickHouse#56014) * Removed unused code in google-protobuf-cmake/CMakeLists.txt (ref: ClickHouse/ClickHouse#56102) * Bump gRPC to v1.55.4 and protobuf to v22.5 (ref: ClickHouse/ClickHouse#56664) * Bump gRPC to v1.59 and protobuf to v24.4 (ref: ClickHouse/ClickHouse#56853) * enable functions in readonly mode (ref: ClickHouse/ClickHouse#42708) * Introduce more fields for in-source function documentation (ref: ClickHouse/ClickHouse#49300) * Add ability to convert timeplusd table structure to CapnProto/Protobuf format schema (ref: ClickHouse/ClickHouse#52278) * Well known protos (ref: ClickHouse/ClickHouse#56741) * Update protobuf to v25.1 (ref: ClickHouse/ClickHouse#58020) * fixed unit_tests_dbms build * Avoid ignoring errors of execute_process() (set COMMAND_ERROR_IS_FATAL=ANY) (ref: ClickHouse/ClickHouse#68267) * fixed reigsterFunction * fixed error after rebase
* Merge pull request #51710 from velavokr/velavokr-warn-cpu-utilization A cmake warning on job limits underutilizing CPU * Merge pull request #52196 from rschu1ze/simplify-job-limiting CMake: Simplify job limiting * Merge pull request #56971 from ClickHouse/own-cmake-for-grpc Own CMake for GRPC * Merge pull request #70671 from ClickHouse/fix-native-macos Fix native macOS build --------- Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com> Co-authored-by: Robert Schulze <robert@clickhouse.com> Co-authored-by: Konstantin Bogdanov <thevar1able@users.noreply.github.com>
* Port ClickHouse #44132 Bump libdivide (to gain some new optimizations) * Merge pull request #62212 from ClickHouse/clang-19-3 Fix build with clang-19 (master) * Porting ClickHouse #70412 Fix `clang-19` build issues * Comment out unnecessary include files to fix mac build issue * Port ClickHouse #70691 Bump `arrow` to v16.1.0 and `flatbuffers` to v23.5.26 --------- Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com> Co-authored-by: Konstantin Bogdanov <thevar1able@users.noreply.github.com> Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com> Ported by: sunset3000 <tian.fan@timeplus.io>
`clang++-19: error: no such include directory: '/proton/src/ch_contrib::rapidjson' [-Werror,-Wmissing-include-dirs]`
45296d7
to
6e87806
Compare
Co-authored-by: yun <haohang.shi@timeplus.io>
6e87806
to
c97b232
Compare
zliang-min
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one comment.
sorry, i need overwrite CLA. credit: ClickHouse/ClickHouse#51285
2220935
to
6a70af0
Compare
This was
linked to
issues
Mar 4, 2025
Open
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please write user-readable short description of the changes:
Try fixing the clang19 build. The key is flatbuffer required an upgrade, but considering the protobuff is out of date, I bumped it up as well. Some basic test cases have already run.
test log
with proton 1.6.11-rc:
proton new version
docker pull ghcr.io/timeplus-io/proton:rel-45296d7