Respect other extensions' ExecutorStart hooks #7712
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akuzm, @svenklemm: please review this pull request.
|
When we override ExecutorStart hook that has been set by another extension we have to chain-call it not to disrupt other extension's integrity.
zilder
force-pushed
the
zilder/chain_executor_start_hook
branch
from
ccac202 to
34fa509
Compare
|
Similar to #7694 |
mkindahl
approved these changes
Feb 14, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7712 +/- ##
==========================================
+ Coverage 80.06% 81.93% +1.86%
==========================================
Files 190 246 +56
Lines 37181 45120 +7939
Branches 9450 11256 +1806
==========================================
+ Hits 29770 36970 +7200
- Misses 2997 3732 +735
- Partials 4414 4418 +4 ☔ View full report in Codecov by Sentry. |
fabriziomello
approved these changes
Feb 14, 2025
svenklemm
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #7667.
When we override ExecutorStart hook that has been set by another extension we have to chain-call it not to disrupt other extension's integrity.