Remove unrequired pending tests

timgent · Jul 14, 2020 · ddbe96f · ddbe96f
1 parent 3f41f48
commit ddbe96f
Showing 1 changed file with 7 additions and 38 deletions.
diff --git a/src/test/scala/com/github/timgent/sparkdataquality/metrics/MetricCalculatorTest.scala b/src/test/scala/com/github/timgent/sparkdataquality/metrics/MetricCalculatorTest.scala
@@ -1,6 +1,12 @@
 package com.github.timgent.sparkdataquality.metrics
 
-import com.github.timgent.sparkdataquality.metrics.MetricCalculator.{ComplianceMetricCalculator, DistinctValuesMetricCalculator, SimpleMetricCalculator, SizeMetricCalculator, SumValuesMetricCalculator}
+import com.github.timgent.sparkdataquality.metrics.MetricCalculator.{
+  ComplianceMetricCalculator,
+  DistinctValuesMetricCalculator,
+  SimpleMetricCalculator,
+  SizeMetricCalculator,
+  SumValuesMetricCalculator
+}
 import com.github.timgent.sparkdataquality.metrics.MetricValue.{DoubleMetric, LongMetric}
 import com.github.timgent.sparkdataquality.utils.CommonFixtures._
 import com.holdenkarau.spark.testing.DatasetSuiteBase
@@ -36,10 +42,6 @@ class MetricCalculatorTest extends AnyWordSpec with DatasetSuiteBase with Matche
       val letterNotAFilter = MetricFilter('str =!= "a", "letter not equal to a")
       testMetricAggFunction(ds, SizeMetricCalculator(letterNotAFilter), LongMetric(2))
     }
-
-    "return a failure when an invalid filter is given" in { // TODO: Implement error handling for bad metrics
-      pending
-    }
   }
 
   "ComplianceMetricCalculator" should {
@@ -77,14 +79,6 @@ class MetricCalculatorTest extends AnyWordSpec with DatasetSuiteBase with Matche
         DoubleMetric(0.5)
       )
     }
-
-    "return a failure when an invalid filter is given" in { // TODO: Implement error handling for bad metrics
-      pending
-    }
-
-    "return a failure when an invalid compliance fn is given" in { // TODO: Implement error handling for bad metrics
-      pending
-    }
   }
 
   "DistinctValuesMetricCalculator" should {
@@ -114,21 +108,8 @@ class MetricCalculatorTest extends AnyWordSpec with DatasetSuiteBase with Matche
         LongMetric(3)
       )
     }
-
-    "return a failure when an invalid filter is given" in { // TODO: Implement error handling for bad metrics
-      pending
-    }
-
-    "return a failure when an invalid column is given" in { // TODO: Implement error handling for bad metrics
-      pending
-    }
-
-    "return a failure when an empty list of columns is given" in {
-      pending
-    }
   }
 
-
   "SumValuesMetricCalculator" should {
     lazy val ds = Seq(
       NumberString(1, "a"),
@@ -153,17 +134,5 @@ class MetricCalculatorTest extends AnyWordSpec with DatasetSuiteBase with Matche
         LongMetric(6)
       )
     }
-
-    "return a failure when an invalid filter is given" in { // TODO: Implement error handling for bad metrics
-      pending
-    }
-
-    "return a failure when an invalid column is given" in { // TODO: Implement error handling for bad metrics
-      pending
-    }
-
-    "return a failure when the column value can't be summed" in { // TODO: Implement error handling for bad metrics
-      pending
-    }
   }
 }