Bump minimum node version.
#5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing. Is there something I should do? |
|
Looks like CI is failing because there's no |
|
Try adding a file branches:
only:
- "master"
git:
depth: 3
language: node_js
node_js:
- "4"
- "10"
script:
- npm run test |
|
@timoxley What do you think? |
|
I‘d add node 6 and 8 for safety otherwise 👍 |
|
@timoxley Could you check this one out? Thank you! |
|
@timoxley any update on this one? could you please approve and merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To
node>=4. Closes #4.