💄 CMS UI | Updating the Events Component Editor #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to give offsets some context
… in the offset options list, and also the use of a the time picker for the CMS window
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
isaaclombardssw
changed the title
|
Closes #2173. |
bradystroud
requested changes
Oct 8, 2024
There was a problem hiding this comment.
As per our conversation, we need to pick a city, not a timezone. Timezones can change. (daylight savigns)
e.g.
in June, Bob books NDC London for Jan 15th 9am, and sets timezone to Londons current time zone (+1:00 GMT)
London changes from +1:00 GMT to +0:00 GMT on last day of Oct
The event will change from 9am to 8am
bradystroud
approved these changes
Nov 5, 2024
Calinator444
pushed a commit
that referenced
this pull request
Nov 12, 2024
* adding in react-datetime * adding in the hardcoded list of IANA timezone to city name mappings, to give offsets some context * updating the events component by injecting and determining the cities in the offset options list, and also the use of a the time picker for the CMS window * auto-linting stuff and fields added from experimentation (no visual changes * linting error fix * offset hour linting issue – truncation option not recognised * trying new ts ignore locations... * realised I didn't even need the format and can just use trunc * updating the UI message * updating comments and labels * updating pnpm lock * fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two big things here were adding a time picker instead of a number box, and associating major cities to offset values for context (via the moment timezone library).
🤖🤖🤖
This pull request includes significant updates to the
Eventscomponent to improve timezone handling and date formatting, as well as some changes to the JSON data and package dependencies.Updates to
EventsComponent:components/blocks/Events.template.tsx:moment-timezonefor better accuracy and addedDatetimefor date-time input. Updated date and time formatting functions. [1] [2] [3] [4] [5]moment-timezone.components/blocks/Events.tsx:startDateUTC. [1] [2]JSON Data Updates:
components/blocks/EventsTimezones.json: Added a list of major cities and their respective timezones.content/blocksPages/home.json: UpdatedstartTimefields to use ISO 8601 date strings instead of numeric values. [1] [2] [3]Dependency Updates:
package.json: Addedmoment-timezoneandreact-datetimeto dependencies. [1] [2]Code Cleanup:
pages/[slug].tsx: Reorganized import statements for better readability. (pages/[slug].tsxL1-R5)🤖🤖🤖
All New Content Submissions: (To be confirmed by reviewer)