Skip to content

Add ReBRAC configs and source #59

Merged
merged 20 commits into from
Jul 20, 2023
Merged

Add ReBRAC configs and source #59

merged 20 commits into from
Jul 20, 2023

Conversation

DT6A
Copy link
Collaborator

@DT6A DT6A commented Jun 14, 2023

No description provided.

@DT6A
Copy link
Collaborator Author

DT6A commented Jul 17, 2023

@vkurenkov @Scitator @Howuhh review is needed

@vkurenkov
Copy link

I believe we should merge it after #68 is done to avoid noqa

@DT6A
Copy link
Collaborator Author

DT6A commented Jul 17, 2023

I believe we should merge it after #68 is done to avoid noqa

I think we can just live with that

@Howuhh
Copy link
Contributor

Howuhh commented Jul 19, 2023 •
edited
Loading

@DT6A it's time to remove all # noqa once and for all 🙏 ! Merge main, reinstall dev requirements (ruff, pre-commit), and run pre-commit install -> pre-commit run --all-files.

@DT6A
Copy link
Collaborator Author

DT6A commented Jul 19, 2023

@vkurenkov @Howuhh @Scitator ready to merge

Howuhh
Howuhh suggested changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@Howuhh Howuhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add jax dependencies to requirements_dev too

@vkurenkov vkurenkov merged commit 42c9793 into main Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Howuhh Howuhh Howuhh approved these changes

@Scitator Scitator Scitator approved these changes

@vkurenkov vkurenkov vkurenkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DT6A @vkurenkov @Howuhh @Scitator