-
Notifications
You must be signed in to change notification settings - Fork 0
Feat : 파티 목록 디폴트 이미지 필드 추가 #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
74 commits
Select commit
Hold shift + click to select a range
bce7dbc
feat : 닉네임 중복 체크 (nickname unique), 인증코드 검사 예외처리 추가
yyytir777 3573613
fix : user_id IDENTITY strategy & dev redis host 이름변경 (localhost -> r…
yyytir777 08cfb63
test코드 생성 & swagger url 삭제 & 환경변수 중복 삭제
yyytir777 ac96fa0
fix : 엔드포인트 추가
yyytir777 43e75ed
Merge pull request #27 from tinybite-2025/feature/13-user
yyytir777 a70941b
Feature/26 notification (#29)
marshmallowing cbbf597
feat : google login 구현 완료
yyytir777 d03fd30
fix : main push 시에만 workflow trigger
yyytir777 00cc289
Merge branch 'main' of https://github.com/tinybite-2025/tinybite-serv…
yyytir777 729ae0a
Feature/#28 google apple login
yyytir777 b5c29db
Merge branch 'main' into develop
yyytir777 2e5da55
Merge branch 'develop' of https://github.com/tinybite-2025/tinybite-s…
yyytir777 1fbd896
merge main into develop : main의 핫픽스 변경사항 develop에 반영
yyytir777 dd9771a
workflow 줄바꿈 에러 수정
yyytir777 38de611
hotifx : 에러 핸들링 수정 및 무중단 배포 삭제 (리소스 너무 많이 먹음)
yyytir777 91b8cba
main의 핫픽스 develop에 반영
yyytir777 fbc5e90
수정사항 반영 (API 인증 관련, db schema, 예외 처리 등..)
yyytir777 7b9fb7b
main브랜치 핫픽스 반영
yyytir777 bbb080f
Feature/35 term (#38)
yyytir777 4c352aa
fix : docker compose 명령어 수정
yyytir777 27dfcbb
Feature : 파티 기능 (#42)
milowon 0de3a43
Merge branch 'main' into develop
milowon 2f27dee
hotfix : url parser 경로 제거
milowon 6eb0d8d
Merge branch 'main' of https://github.com/tinybite-2025/tinybite-serv…
milowon 3f69bc1
Merge branch 'main' of https://github.com/tinybite-2025/tinybite-serv…
milowon 45191a9
hotfix : 파티 거리 계산 로직 임시 주석 처리
milowon 3a9a6e6
Merge branch 'main' of https://github.com/tinybite-2025/tinybite-serv…
milowon b2ca1f4
hotfix : 파티 수정, 삭제 controller 추가
milowon 38ab16c
hotfix : 선택 값들이 존재할때만 넣도록 수정
milowon 037d2e4
hotfix : 위도, 경도 로직 삭제
milowon 9d305f8
Feat : 마이페이지 참여중인 파티 조회 (#50)
milowon 1cee657
hotfix : user service에 transactional 어노테이션 추가
milowon 5213214
Merge branch 'main' of https://github.com/tinybite-2025/tinybite-serv…
milowon ed3a399
hotfix : 참여중 파티 조회 반환 형식 통일
milowon 374f720
hotfix : 파티 생성, 조회 시, 거리 계산 로직 반영
milowon 4ddfa39
Hotfix: 유저 좌표 입력 requestParam 형식으로 변경
milowon 42bc4d4
Merge branch 'main' into develop
milowon 9ee078a
Merge branch 'main' into develop
milowon 3be9d38
hotfix : 누락된 swagger 문서 수정사항 반영
milowon 89bbef3
Merge branch 'main' into develop
milowon b281a29
feat : 회원 탈퇴 및 재가입 방지, 검증 (#65)
milowon 35a62b7
fix : 파티 수정 버그 픽스 (#67)
milowon a4f3582
hotfix : 탈퇴 유저 마스킹 로직 변경
milowon 9f05a6a
Merge branch 'main' of https://github.com/tinybite-2025/tinybite-serv…
milowon d802e15
feat : 마이페이지에서 참여중,호스트인 파티 구분해서 조회 (#71)
milowon 8715584
Feature/73 search party (#74)
yyytir777 78349d6
fix : 스웨거 description 추가
yyytir777 ba3d9d8
Merge branch 'main' into develop
yyytir777 c15e45b
Feature/73 search party (#76)
yyytir777 92bef29
Merge branch 'main' into develop
yyytir777 bd136de
Fix : 호스트만 있을때는 파티 수정할 수 있도록 변경 (#78)
milowon 5d3e13d
fix : 파티 삭제시 호스트는 현재인원에서 제외하도록 수정 (#80)
milowon 1e5b600
hotfix : jpa 네이밍 및 쿼리 수정
yyytir777 ba4ed25
hotfix : jpa 네이밍 및 쿼리 수정
yyytir777 c2d9465
Merge branch 'main' into develop
yyytir777 0b783c7
feat : 파티 카테고리, 최신순, 거리순 정렬 (#83)
milowon 4474664
Merge branch 'main' of https://github.com/tinybite-2025/tinybite-serv…
milowon 3353068
Feature/44 chat (#82)
yyytir777 6e2450c
hotfix : 파티 삭제 되지 않는 문제 수정 (#86)
milowon b9630cf
hotfix : 파티 수정사항이 db에 반영 되지 않는 문제 수정
milowon 866bb84
feat : 유저 프로필 이미지 수정, 삭제 (#89)
milowon e1fc441
Fix : 유저 프로필 수정, 삭제 (#91)
milowon 64449d4
Merge branch 'main' into develop
milowon 85f9a6e
hotfix: 유저 정보 조회시 프로필 이미지 반환하도록 수정
milowon 17485c9
Fix/party search (#94)
yyytir777 e77c560
feat: 파티 참여, 거절, 종료 알림 연결 (#97)
marshmallowing 2826cae
fix : 마이페이지에서 참여중, 호스트 파티 조회시 최신순으로 조회되도록 수정 (#98)
milowon cf0f51d
Merge branch 'main' into develop
milowon f02e7eb
feat : 파티 생성시 이미지 없을 경우 디폴트 이미지 반환하도록 수정 (#100)
milowon 72accaf
feat: 채팅 알림 단체/개인 구분 (#102)
marshmallowing 8fa6f24
fix : 채팅방 유형 별 알림 변경
yyytir777 0707f62
Feat : 파티 목록 디폴트 이미지 필드 추가 (#104)
milowon 02c3e16
Fix : 파티 썸네일 이미지 주입되도록 value값 수정 (#106)
milowon 5c230a6
Merge branch 'main' into develop
milowon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
cat -n src/main/java/ita/tinybite/domain/party/service/PartyService.java | head -100Repository: tinybite-2025/tinybite-server
Length of output: 5243
🏁 Script executed:
rg -n "getThumbnailIfPresent" src/main/java/ita/tinybite/domain/party/service/PartyService.javaRepository: tinybite-2025/tinybite-server
Length of output: 266
🏁 Script executed:
rg -n "getDefaultImageIfEmpty" src/main/java/ita/tinybite/domain/party/service/PartyService.javaRepository: tinybite-2025/tinybite-server
Length of output: 165
🏁 Script executed:
rg -A 20 "private String getThumbnailIfPresent" src/main/java/ita/tinybite/domain/party/service/PartyService.javaRepository: tinybite-2025/tinybite-server
Length of output: 1038
🏁 Script executed:
rg -A 20 "private String getDefaultImageIfEmpty" src/main/java/ita/tinybite/domain/party/service/PartyService.javaRepository: tinybite-2025/tinybite-server
Length of output: 957
🏁 Script executed:
Repository: tinybite-2025/tinybite-server
Length of output: 233
🏁 Script executed:
rg -B 5 -A 10 "switch.*category" src/main/java/ita/tinybite/domain/party/service/PartyService.javaRepository: tinybite-2025/tinybite-server
Length of output: 1857
🏁 Script executed:
Repository: tinybite-2025/tinybite-server
Length of output: 525
🏁 Script executed:
Repository: tinybite-2025/tinybite-server
Length of output: 55
🏁 Script executed:
Repository: tinybite-2025/tinybite-server
Length of output: 2398
🏁 Script executed:
Repository: tinybite-2025/tinybite-server
Length of output: 2372
🏁 Script executed:
Repository: tinybite-2025/tinybite-server
Length of output: 55
🏁 Script executed:
Repository: tinybite-2025/tinybite-server
Length of output: 192
🏁 Script executed:
Repository: tinybite-2025/tinybite-server
Length of output: 2768
🏁 Script executed:
grep -n "getDefaultImageIfEmpty" src/main/java/ita/tinybite/domain/party/service/PartyService.javaRepository: tinybite-2025/tinybite-server
Length of output: 165
🏁 Script executed:
Repository: tinybite-2025/tinybite-server
Length of output: 142
🏁 Script executed:
sed -n '700,750p' src/main/java/ita/tinybite/domain/party/service/PartyService.javaRepository: tinybite-2025/tinybite-server
Length of output: 1732
🏁 Script executed:
Repository: tinybite-2025/tinybite-server
Length of output: 55
🏁 Script executed:
sed -n '130,200p' src/main/java/ita/tinybite/domain/party/service/PartyService.javaRepository: tinybite-2025/tinybite-server
Length of output: 2892
🏁 Script executed:
rg -n "def.*updateParty\|updateParty\(" src/main/java/ita/tinybite/domain/party/service/PartyService.javaRepository: tinybite-2025/tinybite-server
Length of output: 55
🏁 Script executed:
sed -n '105,150p' src/main/java/ita/tinybite/domain/party/service/PartyService.javaRepository: tinybite-2025/tinybite-server
Length of output: 1818
🏁 Script executed:
rg -n "void updateParty\|Long updateParty" src/main/java/ita/tinybite/domain/party/service/PartyService.javaRepository: tinybite-2025/tinybite-server
Length of output: 55
🏁 Script executed:
rg -B 3 -A 40 "updateParty.*PartyUpdateRequest" src/main/java/ita/tinybite/domain/party/service/PartyService.javaRepository: tinybite-2025/tinybite-server
Length of output: 1770
getThumbnailIfPresent/getThumbnailDetailIfPresent의 category 방어 로직 추가 필요PartyCreateRequest에서@NotNull로 검증되어 null은 방지되지만,PartyCategory.ALL값이 들어올 경우 현재 switch 문의default케이스에서 예외를 던집니다. 다음과 같이 명시적으로 처리하는 것이 좋습니다:제안 diff
private String getThumbnailIfPresent(List<String> images, PartyCategory category) { if (images != null && !images.isEmpty()) { return images.get(0); } + if (category == PartyCategory.ALL) { + throw new IllegalArgumentException("파티 생성/수정에는 ALL 카테고리를 사용할 수 없습니다"); + } return switch (category) { case DELIVERY -> defaultDeliveryImage; case GROCERY -> defaultGroceryImage; case HOUSEHOLD -> defaultHouseholdImage; default -> throw new IllegalArgumentException("존재하지 않는 카테고리입니다: " + category); }; }또한
getDefaultImageIfEmpty()는 정의되어 있으나 코드 전체에서 호출되지 않으며, 하드코딩된 경로를 반환하므로 혼동을 야기합니다. 미사용 메서드이므로 삭제하기를 권장합니다.🤖 Prompt for AI Agents