-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor agentql
repo
#97
Changes from 3 commits
3090773
b91744c
6a02c11
9ff75bd
ff35aa1
8c05870
283b797
525bb96
be40f94
1df26ae
d646845
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
name: JSPre-commit checks | ||
|
||
on: | ||
pull_request: | ||
types: [opened, synchronize, reopened] | ||
paths: | ||
- "examples/JS/**" | ||
|
||
jobs: | ||
js-pre-commit: | ||
name: JS Pre-commit checks | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout Repository | ||
uses: actions/checkout@v4 | ||
|
||
- name: Setup Node.js | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: "18" | ||
|
||
- name: Install dependencies | ||
working-directory: ./examples/JS | ||
run: npm install | ||
|
||
- name: Run ESLint | ||
working-directory: ./examples/JS | ||
run: npm run lint | ||
|
||
- name: Run Prettier | ||
working-directory: ./examples/JS | ||
run: npx prettier --check . |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,7 @@ | |
}, | ||
"eslint.workingDirectories": [ | ||
{ | ||
"directory": "./javascript-sdk", | ||
"directory": "./examples/JS", | ||
"changeProcessCWD": true | ||
} | ||
], | ||
|
@@ -34,8 +34,8 @@ | |
], | ||
"pylint.importStrategy": "fromEnvironment", | ||
"pylint.args": [ | ||
"--rcfile=.pylintrc" | ||
"--rcfile=./examples/Python/.pylintrc" | ||
], | ||
"python.analysis.typeCheckingMode": "standard", | ||
"python.analysis.typeCheckingMode": "basic", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why and what's the difference? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My initial thinking is that "basic" is more lenient in terms of reporting static type warnings/errors and might make it easier for others to contribute. But on a second thought, we should probably still make it standard to ensure code quality -- I will revert the change |
||
"editor.rulers": [100] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't use capitalized folder names