Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deno environment variable support #316

Merged
merged 2 commits into from
Dec 28, 2024
Merged

fix: deno environment variable support #316

merged 2 commits into from
Dec 28, 2024

Conversation

veryCrunchy
Copy link
Contributor

@veryCrunchy veryCrunchy commented Dec 28, 2024 •
edited
Loading

Denos process.env booleans have a boolean type, causing the check to always return false

@veryCrunchy veryCrunchy requested a review from a team as a code owner December 28, 2024 04:38
MARCROCK22
MARCROCK22 previously approved these changes Dec 28, 2024
View reviewed changes
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 28, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/tiramisulabs/seyfert@316

commit: e458288

@veryCrunchy
Copy link
Contributor Author

@MARCROCK22 you made a nono in review

@veryCrunchy
Copy link
Contributor Author

OMFG

@MARCROCK22
Copy link
Member

XD

@veryCrunchy
Copy link
Contributor Author

There 😭

@MARCROCK22 MARCROCK22 merged commit ce86aa7 into tiramisulabs:main Dec 28, 2024
2 checks passed
@veryCrunchy veryCrunchy deleted the env-deno-support branch December 28, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MARCROCK22 MARCROCK22 MARCROCK22 approved these changes

@socram03 socram03 socram03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veryCrunchy @MARCROCK22 @socram03