-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: audio auto play support AmE, BrE and disabled options #819
base: dev
Are you sure you want to change the base?
Conversation
I have closed #817 because I copied main branch only yesterday. |
I suggest not modifying the Especially considering that later on, we might add an option to automatically play the queried text, not just English words. |
I got it, I'll put back |
@tisfeng Add a new option for selecting pronunciation only. Preview.mp4 |
Good job! I suggest not binding the English pronunciation method with |
Besides Youdao, there are other TTS services that also support British/American accents, such as Baidu and Bing. If you're interested, you can submit another PR later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Resolves #664
Update General tab as below.