Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: audio auto play support AmE, BrE and disabled options #819

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

devswi
Copy link

@devswi devswi commented Feb 13, 2025

Resolves #664

Update General tab as below.

CleanShot 2025-02-13 at 11 16 49@2x

@devswi
Copy link
Author

devswi commented Feb 13, 2025

I have closed #817 because I copied main branch only yesterday.

@tisfeng
Copy link
Owner

tisfeng commented Feb 15, 2025

I suggest not modifying the autoPlayAudio option. We should add a new pronunciation option instead. Mixing them together will complicate the options.

Especially considering that later on, we might add an option to automatically play the queried text, not just English words.

@devswi
Copy link
Author

devswi commented Feb 17, 2025

I got it, I'll put back autoPlayAudio property as boolean and add a new pronunciation option.

@devswi
Copy link
Author

devswi commented Feb 17, 2025

@tisfeng Add a new option for selecting pronunciation only.

Preview.mp4

@tisfeng
Copy link
Owner

tisfeng commented Feb 18, 2025

Good job!

I suggest not binding the English pronunciation method with autoPlayAudio, it should be a separate option because besides automatic playback, there's also manual playback, and users will need this option in that case.

@tisfeng
Copy link
Owner

tisfeng commented Feb 18, 2025

Besides Youdao, there are other TTS services that also support British/American accents, such as Baidu and Bing.

If you're interested, you can submit another PR later.

Copy link
Owner

@tisfeng tisfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants