Refactorings and adding pydantic #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @skuam, sorry for taking so long to get back. I just saw your PR and it looks amazing! I am not sure if I will have time to test it. However, if you can fix the conflict, I am more than happy to merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I found your project and that was exactly what I needed, but it rather crude form and the overall quality of code seemed not satisfactory to me. So I fixed up the code and made it a bit more clear and general. Overall functionality remains unchanged. Mainly, I changed the way you call to do it through class, so there is no global GLOBIT variable and it is more configurable and put all flying dictionaries with data into proper Pydantic classes, so it is easier for any application to ingest the data. Feel free to either disregard this pull request or merge it if you like the changes.