Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wali] Add WALI initial setup #268

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[wali] Add WALI initial setup #268

wants to merge 2 commits into from

Conversation

MSMazaya
Copy link

  • Added syscall definitions needed for IWASM to compile.
  • Added minimal setup for testing syscalls implementation.

titzer
titzer reviewed Jan 29, 2025
View reviewed changes
Copy link
Owner

@titzer titzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good.

Can you check in the .wasm files and also add .wasm.exit files that will get picked up to check the exit code of the tests?

src/modules/wali/x86-64-linux/X86_64LinuxWaliModule.v3
);
}
def fcntl(args: Range<Value>) -> HostResult {
return HostResult.Throw(Exit.new(1));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per discussion today, this should be a Trap with a TrapReason.UNIMPLEMENTED.

test/wali/Lseek.v3
var ret = wali.SYS_lseek(i32.view(fd), 0, SEEK_SET);
wali.SYS_read(i32.view(fd), Pointer.atContents(second_read), second_read.length);
wali.SYS_close(i32.view(fd));
if (ret != -1 && equal(first_read, second_read))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add a .exit file for this test too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titzer titzer titzer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MSMazaya @titzer