fix: uses of ucal_getHostTimeZone on systems that don't have it
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compile-time Windows version check is not a reliable way of checking whether the system has the `ucal_getHostTimeZone` function in its icu.dll. That function is only available since ICU 65, which only ships on Windows 11 and newer. Supporting that is not worth the hassle, so we keep the "manual" version (for now).
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compile-time Windows version check is not a reliable way of checking whether the system has the
ucal_getHostTimeZonefunction in its icu.dll. That function is only available since ICU 65, which only ships on Windows 11 and newer. Supporting that is not worth the hassle, so we keep the "manual" version (for now).Fixes #33.