Refactor bootstrap controller to move filter behavior to entity #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to follow Clean Architecture:
Note
Controller (in stunmesh is UseCase) should not know the
*config.Config
The current design will use
config.Config.Interfaces
is not a good design. Therefore we should stop using more.To improve it, the
Allowed Peers
will filter by*entity.PeerFilterService
to provide a high-level business logic.It will return all peers using object implements
entity.PeerSearcher
to look up any peers by device name. Then filter it byentity.PeerAllower
which answers aentity.PeerId
is found in config or not.