Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HMACAuthenticationAttribute.cs #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update HMACAuthenticationAttribute.cs #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions HMACAuthentication.WebApi/Filters/HMACAuthenticationAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,14 @@ private bool isReplayRequest(string nonce, string requestTimeStamp)

var serverTotalSeconds = Convert.ToUInt64(currentTs.TotalSeconds);
var requestTotalSeconds = Convert.ToUInt64(requestTimeStamp);


//here need additional check for requestTotalSeconds variable
//for example if requestTotalSeconds more on one second(because request host has different time),
//result of statement serverTotalSeconds - requestTotalSeconds
//will be very big value and not negative as expected so all request will treated as reply attack and rejected
//check code in comment for this file.
//suggestion is - convert to signed integer, so even if request local time will be far away from server time it will be
//still processed
if ((serverTotalSeconds - requestTotalSeconds) > requestMaxAgeInSeconds)
{
return true;
Expand Down Expand Up @@ -199,4 +206,4 @@ public async Task<HttpResponseMessage> ExecuteAsync(CancellationToken cancellati
return response;
}
}
}
}