feat: use mpc-signing-kit instead of tss-client #8
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,27 +5,39 @@ import PackageDescription | |
|
|
||
| let package = Package( | ||
| name: "Web3SwiftMpcProvider", | ||
| platforms: [.iOS(.v14), .macOS(.v11)], | ||
|
There was a problem hiding this comment. What is needed in v14? |
||
| products: [ | ||
| .library( | ||
| name: "MPCEthereumProvider", | ||
| targets: ["MPCEthereumProvider"]), | ||
| .library( | ||
| name: "MPCBitcoinProvider", | ||
| targets: ["MPCBitcoinProvider"]), | ||
|
Comment on lines
10
to
+15
There was a problem hiding this comment. This will have to be condensed into single export for cocoapods |
||
|
|
||
|
|
||
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/argentlabs/web3.swift", from:"1.6.0"), | ||
| .package(url: "https://github.com/tkey/mpc-core-kit-swift", .exact("1.0.0-alpha")), | ||
|
Comment on lines
-17
to
+21
There was a problem hiding this comment. This inverts the dependencies. This library is supposed to be consumed by mpc-core-kit, not the other way round. Since you'll not get an optional import of multiple providers, they will be bundled together, I'd suggest looking into the facade design pattern in swift for how to properly wrap this in mpc-core-kit. This will also eliminate problems as seen in #10 You also need to tag the releases with a semver version, the "-alpha" tag will cause issues. |
||
| ], | ||
| targets: [ | ||
|
|
||
| .target( | ||
| name: "MPCEthereumProvider", | ||
| dependencies: ["web3.swift", | ||
| .product(name: "mpc-core-kit-swift", package: "mpc-core-kit-swift") | ||
| ], | ||
| path: "Sources/EthereumProvider" | ||
| ), | ||
| .target( | ||
| name: "MPCBitcoinProvider", | ||
| dependencies: [.product(name: "mpc-core-kit-swift", package: "mpc-core-kit-swift")], | ||
| path: "Sources/BitcoinProvider" | ||
| ), | ||
| .testTarget( | ||
| name: "Web3SwiftMpcProviderTests", | ||
| dependencies: ["MPCEthereumProvider"], | ||
| path: "Tests"), | ||
| ] | ||
| // swiftLanguageVersions: [.v5] | ||
| ) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| // | ||
| // File.swift | ||
| // | ||
| // | ||
| // Created by CW Lee on 25/01/2024. | ||
| // | ||
|
|
||
| import Foundation | ||
| import mpc_core_kit_swift | ||
|
|
||
| public protocol ISigner { | ||
|
There was a problem hiding this comment. Are you using a fork of the horizontalsystems repo for this? |
||
| func sign( message: Data ) -> Data | ||
| func schnorrSign(message: Data, publicKey: Data) -> Data | ||
| var publicKey : Data { get } | ||
| } | ||
|
|
||
|
|
||
| extension MpcCoreKit : ISigner { | ||
| public func sign(message: Data) -> Data { | ||
| let data = self.tssSign(message: message) | ||
| return data | ||
| } | ||
|
|
||
| public func schnorrSign(message: Data, publicKey: Data) -> Data { | ||
| return Data() | ||
|
There was a problem hiding this comment. We'd need to implement this. There was a problem hiding this comment. not until frost is implemented in rust |
||
| } | ||
|
|
||
| public var publicKey: Data { | ||
| return self.getTssPubKey() | ||
| } | ||
|
|
||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependency should not be needed here.