Skip to content

Major swift changes #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Major swift changes #26

wants to merge 10 commits into from

Conversation

@moeodeh3
Copy link
Contributor

@moeodeh3 moeodeh3 commented Oct 6, 2025 •
edited
Loading

  • add auth proxy support in TurnkeyHttp
  • add auth abstractions in TurnkeySwift
    - initOtp()
    - verifyOtp()
    - loginWithOtp()
    - signUpWithOtp()
    - completeOtp()

dioKaratzas
dioKaratzas reviewed Oct 16, 2025
View reviewed changes
Sources/TurnkeySwift/Public/TurnkeyContext+AuthProxy.swift

do {
// generate the keypair up front
let generatedPublicKey = try createKeyPair()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think public key should be injected here like loginWithOtp does

let resolvedPublicKey = try publicKey ?? createKeyPair()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dioKaratzas dioKaratzas dioKaratzas left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@moeodeh3 @dioKaratzas @taylorjdawson