Add GPXTrack.get_nearest_locations method #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also trivial typing fixes elsewhere
tkrajina
force-pushed
the
dev
branch
2 times, most recently
from
352c97d
to
b866ab4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_nearest_locations works just across the entire GPX database, which is fine for some uses, but if one is trying to match up all the waypoints against tracks (which could be used for an individual part of a trip), there is no way to just match against a track.
Luckily the fix is trivial, unfortunately it is cut-and-paste since we don't inherit from a more generic track vs tracks object.
This pull request also includes #272, please don't apply both. Just giving you the option to decide if you want the added functionality or just the bug fix