Refactor: extract HandlerHelper, fix duplication, add superclass traversal#12
Merged
unknowIfGuestInDream merged 3 commits intomasterfrom Feb 28, 2026
Merged
Conversation
…improve logging and inherited method support Co-authored-by: unknowIfGuestInDream <57802425+unknowIfGuestInDream@users.noreply.github.com>
… logging, fix record accessor calls Co-authored-by: unknowIfGuestInDream <57802425+unknowIfGuestInDream@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor project code for optimization
Refactor: extract HandlerHelper, fix duplication, add superclass traversal
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 4 handler classes duplicated ~80% of their code (editor extraction, AST parsing, indentation, VariableFinder, document insertion). Several bugs and anti-patterns present.
Structural
HandlerHelperutility class with shared logic, reducing handler LOC from ~500 to ~190VariableFinderimplementations into one (withVariableDeclarationStatementfallback)recordforEditorContextBug fixes / correctness
Activator: moveplugin = thisfrom constructor tostart()— constructor runs before OSGi lifecyclee.printStackTrace()→ null-safeILog-based loggingStringBuilder sbbuilt but never read in 3 handlerslines.isEmpty()in converter handler (list always has ≥2 entries)propName.length() == 0→propName.isEmpty()indent += cin loop →StringBuilderFunctional improvement
collectSetters()/collectGetters()now traverse the superclass hierarchy viagetSuperclass(), stopping atjava.lang.Object. Previously onlygetDeclaredMethods()was called, missing inherited methods.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
mirrors.aliyun.com/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.12/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.12/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.12 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.12/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/eclipse-generateAllSetter/eclipse-generateAllSetter org.codehaus.plexus.classworlds.launcher.Launcher clean verify(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.