-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
freebsd, netbsd: add directory; pkg, pkgin: add page #11313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The directory changes LGTM. Thanks.
Nitpick: I would suggest moving the install and remove examples to the top of the pages.
Excerpts from the chatroom (OpenBSD addition discussion)
Someone seems to have opened a PR to add pages for openbsd in a new directory #10698, which is suggested in #816. What do you guys think, can we go ahead with the addition of new directory.
Yea I wasn't sure about possibly adding so many new platforms (openbsd, freebsd, netbsd, ...), as having one bsd platform would be so nice, but also probably impossible, because, as some have already pointed out, the BSD-derivates are very different in some aspects (a good example of this actually is mktemp). So it just went on my mental list of things to reply to "later". I think adding an openbsd platform here (i.e. merging the PR, assuming the pages are good) is probably the right judgement
It is indeed better to have BSD platforms added in a single go than adding them later for updating the clients + These projects pass the notability criteria to be added to tldr.
I've read pretty much this exact take from multiple people in the discussions around BSD platforms and I'm not sure I understand what you're referring to. Shouldn't a well-written client be able to display any page from any platform, as long as it exists? I'm aware of the fact that some clients (I checked a few, apparently most clients) might choose to make platforms, for example, an enum type and thereby check it's a platform the client knows about. But I don't think that's the right solution, at least in most cases. In my opinion, clients should be able to look at the |
Agreed, this is something that we should define with a suggested clause in the client specification (will add it to the tracker issue). However, it would probably be difficult to implement in a majority of the community clients as they are all different implementations in various programming languages. In the case of the official clients, a few ones like the web client from the in-browser app, Node client does require manually updating the platforms for various reasons like Unit tests (in Node client which we specify a template page), etc. Edit. Updated the tracker issue. |
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
common
,linux
,osx
,windows
,sunos
,android
, etc.This PR adds the
freebsd
andnetbsd
directories and pages for their package managers.We definitely don't want to add a big amount of platform directories. I'd like to hear everyone's opinion on adding more BSDs. I think those are the three most popular ones (+OpenBSD), and I wouldn't add any more myself after this.
Each platform addition requires updating all the clients, so adding them all in one go would be ideal.
Discussed in #10698.
Closes #7077.