Adds to DER format of ECDSA signature with extended ECDSA-Sig-Value and ECDSA-Full-R #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I will provide more coverage for the newly added code, as the results of the checks indicate coverage decline. |
gstarovo
force-pushed
the
ecdsa-sig-extend
branch
5 times, most recently
from
0961801 to
e17d333
Compare
gstarovo
force-pushed
the
ecdsa-sig-extend
branch
from
e17d333 to
7f2a47b
Compare
| name, verifying_key, _ = draw(st.sampled_from(keys_and_sigs)) | ||
| note("Configuration: {0}".format(name)) | ||
| order = int(verifying_key.curve.order) | ||
| generator = verifying_key.curve.generator |
Check notice
Code scanning / CodeQL
Unused local variable Note test
gstarovo
force-pushed
the
ecdsa-sig-extend
branch
from
7f2a47b to
19ac7b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes expand encoding/decoding of the ECDSA signature in DER format: expanded ECDSA-Sig-Value format and ECDSA-Full-R.
The definition of the formats can be found in document section C.5, page 114.
The changes bring supporting functions like encoding and decoding of boolean according to ASN.1 standard.
Beside that, the changes add parameter and slightly modifies ECDSA signing function for enabling return of the whole point (instead of 'r').
The testing coverage of encoding/decoding with new function is also present.
Also, there are some formatting changes made with black formatter.