Python 3.12 asyncore to asyncio

[FosanzDev]

Since asyncore is not available in python 3.12+, an alternative is added using asyncio.

The asyncore alternative will only be imported if available, so both options are available for Python 3.11 (or less) users.

---

This change is 

[tomato42]

pep8 errors in codeclimate are relevant

[tomato42]

Codeclimate marks (wrongly) similarities in two completely different methods.

yes, it's a bit too sensitive, don't worry about this, won't block merge based on that

that being said, the failures on python 2.7 are relevant too (possibly other versions), please address those too

[FosanzDev]

that being said, the failures on python 2.7 are relevant too (possibly other versions), please address those too

On it tomorrow!

[tomato42]

unfortunately removing the accent only in the last patch will not work for the bisection tests... :( you'll need to fixup the previous patch with this change

[FosanzDev]

Best way to do this?
New branch from my branch, doing a pr and merging in my repo will work with this?
Anyways I have to add try-except block since asyncio is not in python2 :/

[tomato42]

feel free to rebase the patches and force push to this branch; that's why we use Reviewable, so that rebased patches are still easy to review

[FosanzDev]

Force pushing interactive rebases 3 times is wild, but code and commits are definitely cleaner!

[tomato42]

I won't call it wild until we go into double digits :)

overall looks good, but we need the CI passing before I'll merge it

Reviewed 3 of 3 files at r7, 3 of 3 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @FosanzDev)

[FosanzDev]

I didn't realize that ImportError was risen by Python 2 CI runs. Anyways, it is solved now. CI on Python 3.8 failed due to some error on coveralls.
Hearing back from you.

[tomato42]

Sorry, still see issues with the asyncio import on python 2.7...

[FosanzDev]

My bad. Completely forgot to force-push the actual changes.

[tomato42]

looks like one more test case needs changes

[FosanzDev]

Yeah. Now the errors are in the actual unit test I made for my module. Since it is not available in Python 2, how should I solve this? May I remove the unit test?.

[tomato42]

skip it for the old python versions, there are examples of doing that in other places; just make a comment to make it clear why it's disabled on older pythons

[FosanzDev]

Thanks for the help. I'm not used to unittest.

[FosanzDev]

Ran tests with Python 2 and 3. Now it should work fine. Sorry for the inconvenience!
I did it with trial and error really hehe.

[tomato42]

Reviewed 2 of 3 files at r14, 1 of 4 files at r18, 3 of 3 files at r19, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @FosanzDev)

---

unit_tests/test_tlslite_integration_tlsasynciodispatchermixin.py line 14 at r19 (raw file):

import sys
# No unittest2 features are used in this file

actually there are: skipIf :) that's why py2.6 test run failed
please use

try:
   import unittest2 as unittest
except ImportError:
   import unittest

[FosanzDev]

Reviewable status: 2 of 6 files reviewed, 1 unresolved discussion (waiting on @tomato42)

---

unit_tests/test_tlslite_integration_tlsasynciodispatchermixin.py line 14 at r19 (raw file):

Previously, tomato42 (Hubert Kario) wrote…

actually there are: skipIf :) that's why py2.6 test run failed
please use

try:
   import unittest2 as unittest
except ImportError:
   import unittest

Done.

[tomato42]

Reviewed 1 of 4 files at r20, 3 of 3 files at r21, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @FosanzDev)

[tomato42]

Thanks!