make int_to_bytes and numberToByteArray encode 0 as b'\x00' #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make int_to_bytes() and numberToByteArray() consistent with int().to_bytes() from python3, that means encoding zero as a single null byte, not as an empty byte string
the field is defined as ``` case explicit: opaque DH_Yc<1..2^16-1>; ``` so the share must be at least 1 byte long
Merged
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make int_to_bytes() and numberToByteArray() consistent with int().to_bytes() from python3, that means encoding zero as a single null byte, not as an empty byte string
also fix the bug hidden by it:
ClientKeyExchange: correctly detect too short key shares
the field for DH key shares is defined as
so the share must be at least 1 byte long, update the code to abort if it is too short
This change is