Discord profile plugin example #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xtsukino
approved these changes
Dec 10, 2024
|
TODO:
|
heeckhau
reviewed
Jan 14, 2025
| @@ -0,0 +1,134 @@ | |||
| import { redirect, notarize, outputJSON, getLocalStorageByHost, getHeadersByHost } from '../../../src/utils/hf'; | |||
There was a problem hiding this comment.
This is referencing a JS file in the main boilerplate folder. Is this OK?
Shouldn't we move this to a new npm package that plugins can reuse?
cc @0xtsukino what do you think?
There was a problem hiding this comment.
yea the idea is to turn hf into an npm module.
I also want to extract the plugin host environment in the extension into a separate module for ease of portability. let's leave this hardcoded path in for now, and change it all at once after we deploy the host module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.