Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marco Tiloca's WGLC comments #63

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Marco Tiloca's WGLC comments #63

merged 3 commits into from
Oct 9, 2023

Conversation

thomas-fossati
Copy link
Contributor

@thomas-fossati thomas-fossati commented Oct 6, 2023

This is my initial attempt at addressing Marco's review comments ( #62 ).

Most of his comments were very precise and sensible, so I just applied the suggestion more or less verbatim.


Things not (yet) addressed, which we need to discuss:

  • "I think that another requirement should be that the initiator MUST NOT act on more than one valid path_response or path_drop message for each path_challenge message that it has sent."

I am not sure about this because that's a state that can't materialise if the responder obeys the specified MUSTs:

  • "The responder MUST send exactly one path_response or path_drop message for each received path_challenge."

While in the flow, I reworked / streamlined a bit the intro material. Specifically, I removed the first paragraph fundamentally because it's CID background, which does not really belong here and it's easy to factor out with a single reference to 9146. Besides, Marco's suggested reflow made me realise this paragraph didn't connect well with the surrounding text.


Another bit I've changed is the registration policy for the RRC messages registry. I think it is for a STD/BCP document to change the contents of the registry, rather than pushing the responsibility to the DE.


rendered at: https://tlswg.org/dtls-rrc/marco-wglc-review/draft-ietf-tls-dtls-rrc.html

Also, change registration policy for new RRC messages to STD actions

Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
@thomas-fossati
Copy link
Contributor Author

@boaks @hannestschofenig: if you have time before Monday please have a look and comment, otherwise we will look at it in our call.

draft-ietf-tls-dtls-rrc.md Outdated Show resolved Hide resolved
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
@thomas-fossati thomas-fossati marked this pull request as ready for review October 9, 2023 09:28
@thomas-fossati
Copy link
Contributor Author

thomas-fossati commented Oct 9, 2023

@hannestschofenig @boaks: Given Marco's ACK on the mailing list, I'll go ahead and merge this as agreed in our call this morning.

@thomas-fossati thomas-fossati merged commit f25745d into master Oct 9, 2023
2 checks passed
@thomas-fossati thomas-fossati deleted the marco-wglc-review branch October 9, 2023 13:52
@thomas-fossati thomas-fossati mentioned this pull request Oct 17, 2023
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants