CMake Fixes + RPath #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
badisa
commented
Jan 18, 2026
badisa
commented
- Add RPath to the directory where the Cmake library is exported.
- Remove quotes around some parameters
* No reason to do this
| ], | ||
| extras_require={ | ||
| "dev": ["ruff==0.9.3", "mypy==1.14.1", "pre-commit==4.1.0", "tbump==6.11.*"], | ||
| "dev": ["ruff==0.9.3", "mypy==1.14.1", "pre-commit==4.1.0", "tbump==6.11.*", "build"], |
Collaborator
There was a problem hiding this comment.
Could you explain what "build" does here? In my testing I didn't need to make that change to get a wheel built.
Collaborator
Author
There was a problem hiding this comment.
This is the build package in the python -m build --wheel command in the README.
Could also just stay with python setup.py bdist_wheel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.