Add bullet brogue v1.1.1 to mainline CE #724
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added the test fix commits (separate PRs) just to hopefully make the tests pass. Knowing that this change doesn't break CE and RB is important. |
flend
force-pushed
the
feature/bullet_brogue_mainline
branch
from
2b8de68
to
ce62937
Compare
|
Nice, looks fine within the current system. Though now there would be 3 variants, the amount of duplication is adding up. If this is important to merge for web-brogue I'm ok to do so, would like to explore how to dedup the variants 🤔 Wonder if we could just refer to the main Brogue globals where unchanged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add Bullet Brogue v1.1.1 to mainline.
It uses the existing variant framework with very minor extensions.