Conversation
…nd (#302) * fix: handle spaces and quotes in forge filenames w.r.t. run IDs * windows-specific test scripting * add to gitignore * remote temp file * fix for windows
Merging integer/set optimization into dev branch.
Owner
Author
|
This PR will also add #307, avoiding identifier-name clashes. |
Owner
Author
|
This PR also includes auto-loading CnD visualizer specs to Sterling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release PR following #303
This PR implements the optimization features described here. The set-based optimization is still somewhat brittle, but the feature should be made available in preview form.
Known issues:
Combining a partial-instance bound and a partial-instance target is restricted and needs better documentation (e.g., the lower bound of the target must be contained in the upper bound of the run).
The hidden internal relations that convert an integer-optimization problem to a set-optimization problem persist between runs, even into runs that don't use integer optimization. (This is an architectural problem that will require a small amount of refactoring. Forge wasn't originally built to allow removing relations from the model.)
This PR also fixes the verbosity level that triggers collector spam for debugging; 5 ("HIGH") will no longer be enough.
Finally, this PR also expands the run-tests.sh script to no longer attempt to run the SMT backend tests if cvc5 is not on the path. (Aside: I don't have a lot of shell-script experience beyond the basics, so this is a place I would like to request extra review effort.)