Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Box Seeding Documentation to Segmentation Parameter Docs #406

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

freemansw1
Copy link
Member

@freemansw1 freemansw1 commented Feb 9, 2024

Resolves #399 and adds box seeding to our documentation for segmentation parameters.

Worked on with @RBhupi during the tobathon 2024

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@freemansw1 freemansw1 added enhancement Addition of new features, or improved functionality of existing features documentation Updates and improvements to documentation and examples labels Feb 9, 2024
@freemansw1
Copy link
Member Author

@harrietgilmour and @w-k-jones, are you available to review this PR within the next week or so?

Copy link

github-actions bot commented Feb 9, 2024

Linting results by Pylint:

Your code has been rated at 8.72/10 (previous run: 8.72/10, +0.00)
The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the tobathon branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed4c4bf) 56.91% compared to head (333778b) 56.91%.

Additional details and impacted files
@@            Coverage Diff            @@
##           tobathon     #406   +/-   ##
=========================================
  Coverage     56.91%   56.91%           
=========================================
  Files            20       20           
  Lines          3440     3440           
=========================================
  Hits           1958     1958           
  Misses         1482     1482           
Flag Coverage Δ
unittests 56.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harrietgilmour
Copy link
Collaborator

@harrietgilmour and @w-k-jones, are you available to review this PR within the next week or so?

Yes no problem. I can do it next week

@freemansw1
Copy link
Member Author

@harrietgilmour and @w-k-jones, are you available to review this PR within the next week or so?

Yes no problem. I can do it next week

Thanks! Trying to be more deliberate with our review requests.

Copy link
Collaborator

@harrietgilmour harrietgilmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good - clear and concise. Just added a comment to add in a missing "an" but this is very minor.

Copy link
Member

@w-k-jones w-k-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we might want to consider reorganising this a bit in future to add more examples and stop the article from getting too text heavy, but I think it's better to get it published as is

@w-k-jones
Copy link
Member

Also the docstring are wrongly formatted for seed_3D_flag in segmentation.py which is causing the API reference to render incorrectly. I can fix that quickly and add it to this PR

@freemansw1
Copy link
Member Author

Thanks @w-k-jones @harrietgilmour !

@w-k-jones what is our policy on documentation-only PRs? We can merge these right into main, right?

@w-k-jones
Copy link
Member

Thanks @w-k-jones @harrietgilmour !

@w-k-jones what is our policy on documentation-only PRs? We can merge these right into main, right?

Yes, looks like there's no issues with merging into main so I'm happy for you to do that directly

@freemansw1 freemansw1 changed the base branch from tobathon to main February 19, 2024 18:46
@freemansw1 freemansw1 merged commit 8f92d80 into tobac-project:main Feb 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Updates and improvements to documentation and examples enhancement Addition of new features, or improved functionality of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "box" seeding to segmentation documentation
3 participants