-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Box Seeding Documentation to Segmentation Parameter Docs #406
Add Box Seeding Documentation to Segmentation Parameter Docs #406
Conversation
@harrietgilmour and @w-k-jones, are you available to review this PR within the next week or so? |
Linting results by Pylint:Your code has been rated at 8.72/10 (previous run: 8.72/10, +0.00) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## tobathon #406 +/- ##
=========================================
Coverage 56.91% 56.91%
=========================================
Files 20 20
Lines 3440 3440
=========================================
Hits 1958 1958
Misses 1482 1482
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Yes no problem. I can do it next week |
Thanks! Trying to be more deliberate with our review requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good - clear and concise. Just added a comment to add in a missing "an" but this is very minor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we might want to consider reorganising this a bit in future to add more examples and stop the article from getting too text heavy, but I think it's better to get it published as is
Also the docstring are wrongly formatted for |
Thanks @w-k-jones @harrietgilmour ! @w-k-jones what is our policy on documentation-only PRs? We can merge these right into |
Yes, looks like there's no issues with merging into main so I'm happy for you to do that directly |
Resolves #399 and adds box seeding to our documentation for segmentation parameters.
Worked on with @RBhupi during the tobathon 2024