-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix decorator issues with 1.5.x branch #416
Fix decorator issues with 1.5.x branch #416
Conversation
Linting results by Pylint:Your code has been rated at 8.68/10 (previous run: 8.68/10, +0.00) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## RC_v1.5.x #416 +/- ##
=============================================
+ Coverage 57.00% 57.17% +0.17%
=============================================
Files 20 20
Lines 3454 3482 +28
=============================================
+ Hits 1969 1991 +22
- Misses 1485 1491 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Could you please provide a short statement why you are using parenthesis after decorator name? Do new style rules apply? Thanks! |
Sean's changes made in #380 allow us to provide keyword options to the decorators to change their behaviour. However, this requires the decorator to be called as a function even when no keywords are provided, hence the added parentheses here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all is perfect. Please go ahead and merge!
This PR fixes issues with the
RC_v1.5.x
branch caused by merging in #380.