Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decorator issues with 1.5.x branch #416

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

freemansw1
Copy link
Member

@freemansw1 freemansw1 commented Mar 13, 2024

This PR fixes issues with the RC_v1.5.x branch caused by merging in #380.

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@freemansw1 freemansw1 added the bug Code that is failing or producing the wrong result label Mar 13, 2024
@freemansw1 freemansw1 added this to the Version 1.5.3 milestone Mar 13, 2024
@freemansw1 freemansw1 marked this pull request as ready for review March 13, 2024 15:08
Copy link

Linting results by Pylint:

Your code has been rated at 8.68/10 (previous run: 8.68/10, +0.00)
The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the RC_v1.5.x branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.17%. Comparing base (df86e7f) to head (3bc47ca).
Report is 9 commits behind head on RC_v1.5.x.

Additional details and impacted files
@@              Coverage Diff              @@
##           RC_v1.5.x     #416      +/-   ##
=============================================
+ Coverage      57.00%   57.17%   +0.17%     
=============================================
  Files             20       20              
  Lines           3454     3482      +28     
=============================================
+ Hits            1969     1991      +22     
- Misses          1485     1491       +6     
Flag Coverage Δ
unittests 57.17% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsenf
Copy link
Member

fsenf commented Mar 15, 2024

Could you please provide a short statement why you are using parenthesis after decorator name? Do new style rules apply? Thanks!

@w-k-jones
Copy link
Member

Could you please provide a short statement why you are using parenthesis after decorator name? Do new style rules apply? Thanks!

Sean's changes made in #380 allow us to provide keyword options to the decorators to change their behaviour. However, this requires the decorator to be called as a function even when no keywords are provided, hence the added parentheses here

@fsenf fsenf self-requested a review March 15, 2024 11:27
Copy link
Member

@fsenf fsenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all is perfect. Please go ahead and merge!

@freemansw1 freemansw1 merged commit c00f118 into tobac-project:RC_v1.5.x Mar 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code that is failing or producing the wrong result
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants