[cpp] Fix more clang-tidy warnings

.clang-tidy

@@ -19,7 +19,6 @@ Checks: >
   clang-diagnostics-*,
 
   concurrency-*,
-  -concurrency-mt-unsafe,
 
   cppcoreguidelines-*,
   -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
@@ -41,12 +40,10 @@ Checks: >
 
   readability-*,
   readability-identifier-naming,
-  -readability-function-cognitive-complexity,
   -readability-identifier-length,
 
   -*-avoid-c-arrays,
   -*-magic-numbers,
-  -*-no-malloc,
   -*-vararg,
 
 WarningsAsErrors: "*"
@@ -56,6 +53,10 @@ CheckOptions:
     value: 4
   - key: cppcoreguidelines-avoid-do-while.IgnoreMacros
     value: true
+  - key: readability-function-cognitive-complexity.DescribeBasicIncrements
+    value: false
+  - key: readability-function-cognitive-complexity.Threshold
+    value: 132
   - key: readability-identifier-naming.ClassCase
     value: CamelCase
   - key: readability-identifier-naming.PrivateMemberPrefix

src/cpp/pffdtd/engine_sycl_3d.cpp

@@ -148,7 +148,7 @@ auto run(Simulation3D<Real> const& sim) -> void {
       auto gh1       = sycl::accessor{gh1_buf, cgh, sycl::read_write};
       auto vh1       = sycl::accessor{vh1_buf, cgh, sycl::read_write};
       cgh.parallel_for<ApplyBoundaryLoss<Real>>(Nbl, [=](sycl::id<1> id) {
-        auto nb         = id[0];
+        auto nb         = static_cast<int64_t>(id[0]);
         Real _1         = 1.0;
         Real _2         = 2.0;
         int32_t const k = mat_bnl[nb];

src/cpp/pffdtd/utility.hpp

@@ -23,7 +23,7 @@ template<typename T>
   auto* const ptr  = new T[count];
   auto const bytes = static_cast<size_t>(count) * sizeof(T);
   std::memset(static_cast<void*>(ptr), 0, bytes);
-  return reinterpret_cast<T*>(ptr);
+  return ptr;
 }
 
 template<typename T>