[cpp] Add compiler warning flags

tobanteAudio · Sep 17, 2024 · 96f59dc · 96f59dc
1 parent 7becc18
commit 96f59dc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/cpp/CMakeLists.txt b/src/cpp/CMakeLists.txt
@@ -40,7 +40,7 @@ if(PFFDTD_HAS_SYCL)
 endif()
 
 if((CMAKE_CXX_COMPILER_ID STREQUAL "MSVC") OR (CMAKE_CXX_COMPILER_FRONTEND_VARIANT STREQUAL "MSVC"))
-    target_compile_options(pffdtd PRIVATE /W3)
+    target_compile_options(pffdtd PUBLIC /W3)
 else ()
-    target_compile_options(pffdtd PRIVATE -Wno-deprecated-declarations)
+    target_compile_options(pffdtd PUBLIC -Wall -Wextra -Wno-deprecated-declarations)
 endif ()
diff --git a/src/cpp/pffdtd/hdf.hpp b/src/cpp/pffdtd/hdf.hpp
@@ -70,7 +70,7 @@ struct H5FReader {
     auto set   = H5Dopen(_handle, dataset, H5P_DEFAULT);
     auto space = H5Dget_space(set);
 
-    auto ndims = 1UL;
+    auto ndims = 1;
     auto dims  = std::array<hsize_t, 3>{};
     PFFDTD_ASSERT(H5Sget_simple_extent_ndims(space) == ndims);
     H5Sget_simple_extent_dims(space, dims.data(), NULL);