fix(package): build dist/ on prepare so git installs work#197
Open
ramonclaudio wants to merge 1 commit intotobi:mainfrom
Open
fix(package): build dist/ on prepare so git installs work#197ramonclaudio wants to merge 1 commit intotobi:mainfrom
ramonclaudio wants to merge 1 commit intotobi:mainfrom
Conversation
This was referenced Feb 16, 2026
The `qmd` shim expects `dist/qmd.js` but git installs (`npm install -g https://github.com/tobi/qmd`) don't run the build step, so `dist/` never exists. - Add `tsc` to `prepare` — npm runs this after installing deps (including devDeps) for git-based installs - Move `typescript` from peerDependencies to devDependencies so `tsc` is guaranteed available during `prepare` - `2>/dev/null || true` degrades gracefully when tsc is unavailable (registry installs already ship dist/) Fixes tobi#182
ramonclaudio
force-pushed
the
fix/prepare-build-on-install
branch
from
49310c0 to
881109b
Compare
ramonclaudio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm installfrom a cloned repo breaks becausedist/is gitignored andprepareonly runs git hooks. the shim needsdist/qmd.jsand it doesn't exist.Changes
Only touches
package.json(+2/-4):preparetriestscwhendist/is missing, exits 1 if it's still not theretypescriptmoved frompeerDependenciestodevDependenciesdist/already ships in the tarball)no shim changes, no new runtime deps.
Test Plan
fresh clone,
npm install,dist/gets created,./qmd --versionand./qmd statusboth work.npm install -g github:tobi/qmdstill breaks. npm doesn't install devDeps beforeprepareon global git installs (npm/cli#8440), same with bun (oven-sh/bun#10297). can't fix from package.json. now it printsdist/ missingand exits 1 instead of silently doing nothing.