Skip to content

fix(cli): suppress progress bars when not TTY #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dgilperez wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): suppress progress bars when not TTY #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/qmd.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,19 +165,20 @@ const cursor = {
process.on('SIGINT', () => { cursor.show(); process.exit(130); });
process.on('SIGTERM', () => { cursor.show(); process.exit(143); });

// Terminal progress bar using OSC 9;4 escape sequence
// Terminal progress bar using OSC 9;4 escape sequence (TTY only)
const isTTY = process.stderr.isTTY;
const progress = {
set(percent: number) {
process.stderr.write(`\x1b]9;4;1;${Math.round(percent)}\x07`);
if (isTTY) process.stderr.write(`\x1b]9;4;1;${Math.round(percent)}\x07`);
},
clear() {
process.stderr.write(`\x1b]9;4;0\x07`);
if (isTTY) process.stderr.write(`\x1b]9;4;0\x07`);
},
indeterminate() {
process.stderr.write(`\x1b]9;4;3\x07`);
if (isTTY) process.stderr.write(`\x1b]9;4;3\x07`);
},
error() {
process.stderr.write(`\x1b]9;4;2\x07`);
if (isTTY) process.stderr.write(`\x1b]9;4;2\x07`);
},
};

Expand Down Expand Up @@ -1491,7 +1492,7 @@ async function indexFiles(pwd?: string, globPattern: string = DEFAULT_GLOB, coll
const rate = processed / elapsed;
const remaining = (total - processed) / rate;
const eta = processed > 2 ? ` ETA: ${formatETA(remaining)}` : "";
process.stderr.write(`\rIndexing: ${processed}/${total}${eta} `);
if (isTTY) process.stderr.write(`\rIndexing: ${processed}/${total}${eta} `);
}

// Deactivate documents in this collection that no longer exist
Expand Down Expand Up @@ -1682,7 +1683,7 @@ async function vectorIndex(model: string = DEFAULT_EMBED_MODEL, force: boolean =
const eta = elapsed > 2 ? formatETA(etaSec) : "...";
const errStr = errors > 0 ? ` ${c.yellow}${errors} err${c.reset}` : "";

process.stderr.write(`\r${c.cyan}${bar}${c.reset} ${c.bold}${percentStr}%${c.reset} ${c.dim}${chunksEmbedded}/${totalChunks}${c.reset}${errStr} ${c.dim}${throughput} ETA ${eta}${c.reset} `);
if (isTTY) process.stderr.write(`\r${c.cyan}${bar}${c.reset} ${c.bold}${percentStr}%${c.reset} ${c.dim}${chunksEmbedded}/${totalChunks}${c.reset}${errStr} ${c.dim}${throughput} ETA ${eta}${c.reset} `);
}

progress.clear();
Expand Down
Loading