Skip to content

Commit

Permalink
fix(package): update for Android 15 and fix Android emulator CLI
Browse files Browse the repository at this point in the history
release-npm
  • Loading branch information
tobua committed Oct 24, 2024
1 parent b9e4d9a commit 2d150e4
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
7 changes: 6 additions & 1 deletion script/android.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,12 @@ export const android = async (inputs: RunInputs) => {
) {
runInputArguments += ` --mode=${inputs.mode === RunMode.debug ? 'debug' : 'release'}`
if (inputs.device) {
runInputArguments += ` --device=${inputs.device}`
if (inputs.emulator) {
// --deviceId is deprecated, but --device will not work.
runInputArguments += ` --deviceId ${inputs.device}`
} else {
runInputArguments += ` --device ${inputs.device}`
}
}
if (inputs.emulator) {
runInputArguments += ' --active-arch-only' // Speeds up build.
Expand Down
4 changes: 2 additions & 2 deletions template/app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@
"@types/jest": "^29.5.14",
"@types/react": "^18.3.12",
"@types/react-native": "^0.73.0",
"android-sdk-numic-plugin": "^1.0.6",
"android-sdk-numic-plugin": "^1.0.7",
"babel-jest": "^29.7.0",
"icon-numic-plugin": "^1.4.4",
"jest": "^29.7.0",
"numic": "^3.3.0",
"numic": "^3.3.1",
"react-test-renderer": "^18.3.1",
"typescript": "^5.6.3"
},
Expand Down
4 changes: 2 additions & 2 deletions template/default/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@
"@types/react": "^18.3.12",
"@types/react-native": "^0.73.0",
"@types/react-test-renderer": "^18.3.0",
"android-sdk-numic-plugin": "^1.0.6",
"android-sdk-numic-plugin": "^1.0.7",
"babel-jest": "^29.7.0",
"icon-numic-plugin": "^1.4.4",
"jest": "^29.7.0",
"numic": "^3.3.0",
"numic": "^3.3.1",
"react-test-renderer": "18.2.0",
"typescript": "^5.6.3"
},
Expand Down

0 comments on commit 2d150e4

Please sign in to comment.