Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): Removed ulid python package #42

Merged
merged 1 commit into from
Aug 13, 2024
Merged

feat(node): Removed ulid python package #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ml_pipeline_engine/node/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
import typing as t
import uuid

from ulid import ULID

from ml_pipeline_engine.logs import logger_node as logger
from ml_pipeline_engine.module_loading import get_instance
from ml_pipeline_engine.node.enums import NodeTag
Expand All @@ -21,7 +19,7 @@


def generate_pipeline_id() -> uuid.UUID:
return ULID().to_uuid()
return uuid.uuid4()


def generate_node_id(prefix: str, name: t.Optional[str] = None) -> str:
Expand Down
13 changes: 1 addition & 12 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ classifiers = [
[tool.poetry.dependencies]
python = "^3.8"
networkx = ">=3.1,<4.0"
python-ulid = ">=1.1.0,<2.0"
importlib-resources = "^6.4.0"
cachetools = "^5.3.3"
click = "^8.1.7"
Expand Down