Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add arch key to setup-node cached files #4016

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Aug 29, 2023

runner.arch
https://github.com/actions/runner/blob/be65955a9d2503060186d1e8d97a87587051161d/src/Runner.Worker/JobRunner.cs#L149

it seems node-setup always gets stuck for mac. Not sure if this is because we save the same key for both arm64 & x86 for mac.

@codesandbox
Copy link

codesandbox bot commented Aug 29, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
affine-dev-docs ⬜️ Ignored (Inspect) Aug 29, 2023 3:38pm
affine-prod-temp ⬜️ Ignored (Inspect) Aug 29, 2023 3:38pm

@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:39 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:39 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:39 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:39 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:39 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:39 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:39 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:39 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:39 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:39 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:39 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:39 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:39 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (54574e5) 65.16% compared to head (a8d4109) 65.18%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4016      +/-   ##
==========================================
+ Coverage   65.16%   65.18%   +0.01%     
==========================================
  Files         388      388              
  Lines       11821    11821              
  Branches     1169     1169              
==========================================
+ Hits         7703     7705       +2     
+ Misses       3826     3824       -2     
  Partials      292      292              
Flag Coverage Δ
e2e-plugin-test 38.07% <ø> (+0.01%) ⬆️
e2etest 59.94% <ø> (+0.03%) ⬆️
e2etest-macos-latest-x64 ?
e2etest-ubuntu-latest-x64 47.68% <ø> (ø)
e2etest-windows-latest-x64 ?
server-e2etest 42.98% <ø> (ø)
server-test 65.51% <ø> (ø)
unittest 49.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:42 — with GitHub Actions Inactive
@nx-cloud
Copy link

nx-cloud bot commented Aug 29, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a8d4109. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@pengx17 pengx17 changed the title fix: add arch key to setup-node cached fix: add arch key to setup-node cached files Aug 29, 2023
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:43 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:43 — with GitHub Actions Inactive
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a8d4109
Status: ✅  Deploy successful!
Preview URL: https://f8dbb4e5.affine-dev.pages.dev
Branch Preview URL: https://xp-0829-fix-setup-node-cache.affine-dev.pages.dev

View logs

@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:43 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:43 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:43 — with GitHub Actions Inactive
@pengx17 pengx17 requested a review from himself65 August 29, 2023 15:48
@pengx17
Copy link
Collaborator Author

pengx17 commented Aug 29, 2023

It seems one of the setup-node job stuck at posting cache stage
image

https://github.com/toeverything/AFFiNE/actions/runs/6014482081/job/16314419183?pr=4016

@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:57 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:57 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:57 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:57 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development August 29, 2023 15:57 — with GitHub Actions Inactive
@pengx17
Copy link
Collaborator Author

pengx17 commented Aug 29, 2023

Looks like node will store cache regardless the platform's arch. 🤔
https://github.com/actions/setup-node/blob/main/src/cache-restore.ts#L41C3-L41C64

@himself65 himself65 added this pull request to the merge queue Aug 29, 2023
@pengx17
Copy link
Collaborator Author

pengx17 commented Aug 29, 2023

Sumitted an upstream pr: actions/setup-node#843

Merged via the queue into master with commit 3ef0db7 Aug 29, 2023
16 checks passed
@himself65 himself65 deleted the xp/0829/fix/setup-node-cache branch August 29, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants