Add Ecto Type for IP Addresses #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PragTob
approved these changes
Aug 11, 2025
Contributor
PragTob
left a comment
PragTob
left a comment
There was a problem hiding this comment.
Looking good, but I'd like to see an argument why we choose to implement our own over using ecto_network instead.
Otherwise looks good according to my understanding (other than us not specifying :inet as type) - since we're recommending to store it as :inet I'd love a test showcasing storing and retrieving it successfully from such a column - but I can also see how people would think that's overkill.
|
|
||
| @doc false | ||
| @impl Ecto.Type | ||
| def type, do: :string |
Contributor
There was a problem hiding this comment.
I've never done this, but why are we specifying :string here instead of :inet?
It should also be possible, we might also consider instead using INET from ecto_network
Collaborator
Author
|
Nevermind, just use EctoNetwork.INET. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an Ecto type for conveniently casting and storing IP addresses. It also installs sobelow and adds a
mix checkalias.