Support rails8.1 #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokai3594
force-pushed
the
support_rails8.1
branch
from
5ef8eb7 to
eb861b1
Compare
patorash
suggested changes
Feb 9, 2026
ransacker_translator.gemspec
Outdated
| spec.add_development_dependency "base64" | ||
| spec.add_development_dependency "drb" | ||
| spec.add_development_dependency "concurrent-ruby", '1.3.4' | ||
| spec.add_development_dependency "minitest", "= 5.26.1" |
There was a problem hiding this comment.
minitestのバージョンを固定している理由はありますか？
なければ、~> 5.26のようにしておくのがいいのではないかと思います。
| @@ -12,7 +12,18 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| ruby: ['3.0', '3.1', '3.2', '3.3', '3.4'] | |||
There was a problem hiding this comment.
Rubyのバージョン4.0が出ているから、そちらも対応したほうがいいのでは？と思います。
tokai3594
force-pushed
the
support_rails8.1
branch
from
c7c6db2 to
400bd06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
仕様
Rails8.1に対応させる
変更点