Draft
Conversation
…ion plan - Updated @figma/plugin-typings to version 1.121.0 in yarn.lock. - Removed outdated entries for object-inspect, qs, side-channel, string-width, and wrap-ansi from yarn.lock. - Introduced a new document for the implementation plan of Figma extended variable collections, detailing goals, known API observations, data model changes, and a phased approach for development. This commit enhances the project by ensuring up-to-date dependencies and providing a structured plan for future feature development.
🦋 Changeset detectedLatest commit: 7ff4af5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
|
Contributor
|
Commit SHA:338e440f4e0bee5f668c1b0f6708f4bd375c599f Test coverage results 🧪
|
Contributor
|
Commit SHA:338e440f4e0bee5f668c1b0f6708f4bd375c599f |
- Completed Phase 4: Updated variables for extended themes, ensuring inherited variables are protected from deletion and can have override values set. - Completed Phase 5: Introduced UI controls for theme inheritance, allowing users to select a parent theme and displaying inheritance relationships in the theme list. - Updated relevant files to implement and test these features, ensuring all tests pass successfully.
…management - Added detailed debug logging to `createNecessaryVariableCollections`, `findCollectionAndModeIdForTheme`, `setColorValuesOnVariable`, and `setValuesOnVariable` functions to trace collection and mode operations. - Improved error handling in `setColorValuesOnVariable` to ensure graceful failure and logging of issues when setting color values. - Updated `hashFigmaId` to return an empty string instead of null for better consistency in error scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces support for extended collections, wip