feat: Implement deprecated tokens feature#3834
Open
pvignau wants to merge 1 commit intotokens-studio:mainfrom
Open
feat: Implement deprecated tokens feature#3834pvignau wants to merge 1 commit intotokens-studio:mainfrom
pvignau wants to merge 1 commit intotokens-studio:mainfrom
Conversation
🦋 Changeset detectedLatest commit: f46c9e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 10 |
| Duplication | 20 |
TIP This summary will be updated as you push new changes. Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why does this PR exist?
Closes #0000 - No related issue
Hey there, this is a feature proposal. Me and my team struggle with token lifecycle, mainly about token depreciation.
Around this, this is a first draft to work on it and, I hope, define a workflow for this case.
What does this pull request do?
It updates the UI and some token entity attributed (mainly token
deprecatedattribute).Here are the functionality it adds :
Here are some screenshots before and after :








Dashboard - before
Dashboard -after
Creation modal - before
Creation modal - after
Sync variables page - before
Sync variables page - after
Hide deprecated tokens - before
Hide deprecated tokens - after
Deprecated token (DTCG) :
{ "my": { "super": { "deprecated": { "token": { "$deprecated": true, "$type": "color", "$value": "#3488e6" } } } } }Deprecated token (Legacy) :
{ "my": { "super": { "deprecated": { "token": { "value": "#3488e6", "type": "color", "$extensions": { "studio.tokens": { "deprecated": true } } } } } } }Testing this change
You can :
Additional Notes (if any)
I've added some translation (thanks Claude 🤖) but I'm no translator.
If a token is deprecated after the variable is synced and the ignore deprecated tokens switch is on, I've arbitrary chose to let the variable live on its own and not delete it (it'd be deleted if the delete variable w/o sync to a token is checked)
This is my first PR here, don't mind about telling me what's right or wrong :)