Add a config option to avoid passing include_source_info #1212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1213
We already support passing
disable_comments
to disable comment processing during the code generation.However, when we compile FileDescriptorSet, we always pass
--include_source_info
. These might cause a problem, especially when the file is later included into the final binary usinginclude_bytes!
e.g. because of the following:Therefore, adding the
skip_source_info
argument allowing to disable it. Altnerative fix could be to add itprotoc_args
by default, but this is not backwards compatible, becauseprotoc_args
are currently additive only.