Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more no-default-features = false to prost-derive #1217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add more no-default-features = false to prost-derive #1217

wants to merge 1 commit into from

Conversation

kpp
Copy link

@kpp kpp commented Jan 2, 2025

itertools and anyhow bring unnecessary std into prost-derive.

caspermeijn
caspermeijn requested changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@caspermeijn caspermeijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently they are needed, as CI is red :-)

prost-derive is run on the build machine. Why is no-std needed in that case?

@kpp
Copy link
Author

kpp commented Jan 3, 2025

Because it turns on std feature in anyhow

@caspermeijn
Copy link
Collaborator

Because it turns on std feature in anyhow

But that is the anyhow that is a build-dependency, right? As I understand, the anyhow that is built for the no-std target is a different build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspermeijn caspermeijn caspermeijn requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpp @caspermeijn