-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Java from 17 to 21 #2388
Conversation
Hey! Why did you update the npm packages? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will also need to update the docker images to java 21. This is on me.
So they had severe vulnerabilities especially with the packages you use. It's a security flaw while they were outdated for a long time.. Also there is another security flaw which needs to be resolved. I will tell you in Slack while it's not good to mention it here |
Of course! I could do it but if you want it's all yours |
Also consider updating and changing the builder because it's deprecated with the latest Gradle versions. |
What do you mean by the builder? |
If you go and build the docker image you will see you will get a Deprecated message for Gradle 9.0 because you have set the docker builder to 0. You need to either update the builder so it's not deprecated or use the docker builder itself, the builder kit |
I cannot see update of Gradle in your PR. How are you actually running it? |
This PR is stale because it has been open for 30 days with no activity. |
This PR is stale because it has been open for 30 days with no activity. |
This PR was closed because it has been inactive for 14 days since being marked as stale. |
It currently builds and run correctly using Java 21 so its a good update.