Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: import and export support for i18next #2463

Merged
merged 32 commits into from
Oct 1, 2024
Merged

feat: import and export support for i18next #2463

merged 32 commits into from
Oct 1, 2024

Conversation

Anty0
Copy link
Collaborator

@Anty0 Anty0 commented Sep 16, 2024 •
edited
Loading

Supported features in current implementation:

  • Interpolation
    • Replaceable keys
    • Keep unescaped flag
      • Ignored during import
  • Format
    • Number
      • Only without options, otherwise ignored
    • Currency
      • Ignored
    • Datetime
      • Ignored
    • Relativetime
      • Ignored
    • List
      • Ignored
    • Custom format functions
      • Ignored
    • Legacy format function
      • Ignored
  • Plurals
    • Ordinal plurals
    • Interval plurals
      • Imported as normal keys with the text itself containing whole structure describing the interval plural
  • Nesting
    • Ignored
  • Context
    • Imported as normal keys with context as part of the key name

@Anty0 Anty0 mentioned this pull request Sep 16, 2024
Closed
17 tasks
@JanCizmar JanCizmar self-requested a review September 19, 2024 13:06
@Anty0 Anty0 changed the title Import support for i18next feat: tmport support for i18next Sep 19, 2024
@Anty0 Anty0 changed the title feat: tmport support for i18next feat: import support for i18next Sep 19, 2024
@Anty0 Anty0 self-assigned this Sep 19, 2024
@JanCizmar JanCizmar linked an issue Sep 23, 2024 that may be closed by this pull request
Add support for i18next format #2159
Closed
@Anty0
Copy link
Collaborator Author

Anty0 commented Sep 26, 2024

Would you also like me to add the i18next logo to the list of supported formats on import screen?

@JanCizmar
Copy link
Contributor

Would you also like me to add the i18next logo to the list of supported formats on import screen?

Yes. @ZuzanaOdstrcilova can provide it.

JanCizmar
JanCizmar requested changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@JanCizmar JanCizmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the custom merging.

...ata/src/main/kotlin/io/tolgee/formats/genericStructuredFile/in/GenericStructuredProcessor.kt Outdated Show resolved Hide resolved
@Anty0
feat: handle unescaped flag by saving it to the custom values
e424b30
@Anty0
feat: i18next tests
742a6ec
@Anty0
fix: lint
7fd6091
@Anty0
fix: path to resource in tests
239f5c6
@Anty0
feat: add i18next export test
04cee0c
@Anty0
feat: test unecaped placeholder export
7f942e4
@Anty0
fix: typo in icu to i18 placeholder convertor
201ec64
@Anty0
fix: missing comma
107cbb1
@Anty0
fix: tests and breakage after rebase
05d73f2
@Anty0
feat: add i18next logo to import screen
e1feeed
@Anty0
feat: placeholder convertors now use customValuesModifier function to…
171d250 
… report changes to be done to customValues
@Anty0
fix: lint
aa01871
@Anty0
fix: lint
2901e1a
@Anty0
fix: only modify custom values when modifier function was returned
16a2459
@Anty0
fix: bugs found while writing documentation
16fbfa2
@Anty0
fix: handling of missing other + convert to '#' only placeholders wit…
e2a257f 
…hout format
@Anty0 Anty0 changed the title feat: import support for i18next feat: import/export support for i18next Oct 1, 2024
@Anty0 Anty0 changed the title feat: import/export support for i18next feat: import and export support for i18next Oct 1, 2024
@JanCizmar JanCizmar merged commit 8c36fbf into main Oct 1, 2024
29 checks passed
@JanCizmar JanCizmar deleted the i18next-import-support branch October 1, 2024 13:53
TolgeeMachine pushed a commit that referenced this pull request Oct 1, 2024
@semantic-release-bot
chore(release): 3.75.0 [skip ci]
e8efbb3 
# [3.75.0](v3.74.5...v3.75.0) (2024-10-01)

### Features

* import and export support for i18next ([#2463](#2463)) ([8c36fbf](8c36fbf))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanCizmar JanCizmar JanCizmar approved these changes

Assignees

@Anty0 Anty0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for i18next format
2 participants
@Anty0 @JanCizmar